New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid use of sig_on() in acb_calc_func_callback #27428
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Replying to @jdemeyer:
Thanks for the notice. I think I'm unable to fix the issue by myself, unfortunately. Is there a description of What is the proper way to handle the case of (i) an external C library (ii) that performs callbacks into Python code (iii) but not very frequent ones, so that one would like the code running between two callbacks to be interruptible? |
This comment has been minimized.
This comment has been minimized.
comment:4
Replying to @mezzarobba:
Not really, but the important bit to know is that it relies on
How old is your code? That piece of documentation dates from #10109 :-)
It's complicated. The hardest part is dealing with exceptions. I see that you already have provisions for that using the The easy part is making sure that interrupts cannot happen while executing Python code. That can be done with |
comment:6
Wrong ticket? |
Changed branch from u/gh-Hrishabh-yadav/filter_kruskal_spanning_tree to none |
comment:7
Replying to @jdemeyer:
I know, It was a mistake.. How do I remove a branch from a ticket |
comment:8
Replying to @Hrishabh-yadav:
Thanks |
comment:9
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually) |
comment:10
As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9). |
using undocumented cysignal functions sig_block()/sig_unblock(), based on Jeroen Demeyer's indications[1] [1] sagemath#27428 (comment)
using undocumented cysignal functions sig_block()/sig_unblock(), based on Jeroen Demeyer's indications[1] [1] sagemath#27428 (comment)
The function
acb_calc_func_callback
ends with asig_on()
statement. This makes absolutely no sense at all (see https://cysignals.readthedocs.io/en/latest/interrupt.html#using-sig-on-and-sig-off). This was introduced in #24686.In that same function, there is also a bare
except:
which should be fixed toexcept BaseException:
(you really want to catch all exceptions, so it's better to be explicit about that).CC: @mezzarobba
Component: cython
Issue created by migration from https://trac.sagemath.org/ticket/27428
The text was updated successfully, but these errors were encountered: