Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdh_cmake helper #27484

Closed
embray opened this issue Mar 14, 2019 · 8 comments
Closed

Add sdh_cmake helper #27484

embray opened this issue Mar 14, 2019 · 8 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@embray
Copy link
Contributor

embray commented Mar 14, 2019

A few packages which are currently optional are configured using cmake.

We should add a sdh_cmake helper function to sage-dist-helpers analogous to sdh_configure for running cmake with the correct flags for building in Sage.

In particular we need to set CMAKE_INSTALL_PREFIX=$SAGE_LOCAL, and we also need to specify CMAKE_INSTALL_LIBDIR=lib, since otherwise CMake will default to installing libraries to $(prefix)/lib64 on some platforms.

Component: build

Author: Erik Bray

Branch: b0fa3a0

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27484
@embray embray added this to the sage-8.8 milestone Mar 14, 2019
@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

New commits:

b0fa3a0Trac #27484: Add shd_cmake helper for running cmake with the correct flags for

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

Branch: u/embray/build/sdh-cmake

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

Commit: b0fa3a0

@dimpase
Copy link
Member

dimpase commented Mar 14, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 14, 2019

comment:2

LGTM, tested with primecount.

@vbraun
Copy link
Member

vbraun commented Mar 15, 2019

Changed branch from u/embray/build/sdh-cmake to b0fa3a0

@vbraun vbraun closed this as completed in 1cfb97a Mar 15, 2019
@dimpase
Copy link
Member

dimpase commented Mar 18, 2019

Changed commit from b0fa3a0 to none

@dimpase dimpase modified the milestones: sage-8.8, sage-8.7 Mar 18, 2019
This was referenced Mar 18, 2019
Closed
Closed
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 'u/dkrenn/sequences/rec-hash' into u/dkrenn/sequences/k-…
4e7f615 
…regular-guess

* u/dkrenn/sequences/rec-hash: (8211 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 'u/dkrenn/sequences/k-regular-guess' into u/dkrenn/k-reg…
3b0f9d0 
…ular-warning

* u/dkrenn/sequences/k-regular-guess: (8211 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge tag '8.7' into u/dkrenn/joint-spectral-radius
4025684 
SageMath version 8.7, Release Date: 2019-03-23

* tag '8.7': (943 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 'u/dkrenn/k-regular-warning' into u/galipnik/k-regular-b…
9dfa1b3 
…ounded

* u/dkrenn/k-regular-warning: (8211 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@embray @vbraun @dimpase