Remove modification of LD_LIBRARY_PATH from packages flint, arb

[mkoeppe]

We remove the modification of LD_LIBRARY_PATH during the build of package flint, which is unnecessary in sage and not robust (as previously discussed in #24575, it fails on Arch Linux).
This is already merged in upstream FLINT (trunk): flintlib/flint#450
but upstream does not maintain the branch flint-2.5 on which our Sage package is based.

CC: @sebasguts @videlec

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/remove_modification_of_ld_library_path_from_package_flint @ 3ef0928

Issue created by migration from https://trac.sagemath.org/ticket/27750

[mkoeppe]

Branch: u/mkoeppe/remove_modification_of_ld_library_path_from_package_flint

[mkoeppe]

Commit: 3ef0928

[mkoeppe]

New commits:

3ef0928

Don't modify LD_LIBRARY_PATH while buiulding FLINT

[jdemeyer]

comment:3

If you change patches, you should bump the package version.

[embray]

comment:4

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

[mkoeppe]

This has resurfaced, this time on opensuse-tumbleweed-python3.10-minimal https://github.com/mkoeppe/sage/actions/runs/4167928897/jobs/7226558159

 [arb-2.22.1]   Supported LTO compression algorithms: zlib zstd
  [arb-2.22.1]   gcc version 12.2.1 20230124 [revision 193f7e62815b4089dfaed4c2bd34fd4f10209e27] (SUSE Linux) 
  [arb-2.22.1]   ****************************************************
  [arb-2.22.1]   Package 'arb' is currently not installed
  [arb-2.22.1]   No legacy uninstaller found for 'arb'; nothing to do
  [arb-2.22.1]   FLINT_LIB_DIR set to /sage/local/lib
  [arb-2.22.1]   FLINT_INC_DIR set to /sage/local/include
  [arb-2.22.1]   Configuring...x86_64-Linux
  [arb-2.22.1]   Testing __builtin_popcountl...yes
  [arb-2.22.1]   Testing native popcount...yes
  [arb-2.22.1]   Testing __thread...yes
  [arb-2.22.1]   ARB was successfully configured.
  [arb-2.22.1]   Building arb-2.22.1
  [arb-2.22.1]   make AT= QUIET_CC= QUIET_CXX= QUIET_AR=
  [arb-2.22.1]   if [ "1" -eq "1" ]; then \
  [arb-2.22.1]   	make shared; \
  [arb-2.22.1]   fi
  [arb-2.22.1]   /bin/sh: /sage/local/lib/libreadline.so.8: no version information available (required by /bin/sh)
  [arb-2.22.1]   /bin/sh: /sage/local/lib/libreadline.so.8: no version information available (required by /bin/sh)
  [arb-2.22.1]   /bin/sh: /sage/local/lib/libreadline.so.8: no version information available (required by /bin/sh)
  [arb-2.22.1]   /bin/sh: /sage/local/lib/libreadline.so.8: no version information available (required by /bin/sh)
  [arb-2.22.1]   /bin/sh: symbol lookup error: /bin/sh: undefined symbol: rl_trim_arg_from_keyseq, version READLINE_8.2

[mkoeppe]

Outdated after the upgrade to FLINT 3.