-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configure with checks for mpfr, mpc, and ntl #27822
Comments
New commits:
|
Author: Erik Bray |
Branch: u/embray/build/ticket-27822 |
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:3
It occurs to me actually that we probably can't merge any of #27258, #27259, #27265 without this ticket: Due to the changes in Therefore, I believe the other tickets should just be closed, and only this one merged. |
comment:5
please add the last commit on #27265 : |
Updated configure |
comment:7
Attachment: configure-319.tar.gz Rebased again on #27265 and updated the configure tarball. Please double-check I didn't make any mistakes. |
Reviewer: Dima Pasechnik |
comment:8
this appears to be good. |
comment:9
here one has to cherry pick the last commit from public/packages/ntlconf - the one
and redo the configure tarball dance... |
comment:10
configure-319 is the current confball, you always need to increment it |
comment:12
I've rebuilt these tickets dozens of times, it's never clear w.r.t. the release process whether they will be picked in 10 minutes after they are set to positive review, or sit idle for weeks, bit-rotting. |
Changed branch from u/embray/build/ticket-27822 to public/build/ticket-27822 |
This comment has been minimized.
This comment has been minimized.
comment:16
320 is used for 8.8.beta6, can you resolve the merge conflict and make a v321 |
comment:18
sure, as soon as there is a public 8.8.beta6 branch available (nether trac nor github have it) |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:20
rebased over 8.8.beta6, new config tarball (version 321) |
Changed branch from public/build/ticket-27822 to |
This ticket bundles together #27258, #27259, and #27265 in such a way that the configure tarball is updated to contain the configure changes from each of those tickets.
Once all three have been merged (or at the same time) this ticket can also be merged to bump the configure version.
Updated configure:
http://users.ox.ac.uk/~coml0531/sage/configure-321.tar.gz
CC: @dimpase
Component: build: configure
Keywords: spkg-configure mpfr mpc ntl
Author: Erik Bray
Branch/Commit:
cb88c8d
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/27822
The text was updated successfully, but these errors were encountered: