Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure with checks for mpfr, mpc, and ntl #27822

Closed
embray opened this issue May 13, 2019 · 29 comments
Closed

Update configure with checks for mpfr, mpc, and ntl #27822

embray opened this issue May 13, 2019 · 29 comments

Comments

@embray
Copy link
Contributor

embray commented May 13, 2019

This ticket bundles together #27258, #27259, and #27265 in such a way that the configure tarball is updated to contain the configure changes from each of those tickets.

Once all three have been merged (or at the same time) this ticket can also be merged to bump the configure version.

Updated configure:
http://users.ox.ac.uk/~coml0531/sage/configure-321.tar.gz

CC: @dimpase

Component: build: configure

Keywords: spkg-configure mpfr mpc ntl

Author: Erik Bray

Branch/Commit: cb88c8d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27822

@embray embray added this to the sage-8.8 milestone May 13, 2019
@embray
Copy link
Contributor Author

embray commented May 13, 2019

New commits:

d5e5e3dspkg-configure for mpfr, adjustments for its dependees
0329fd9Add one missing SAGE_CONFIGURE_MPFR, for building gcc
d15ead5Trac #27259: spkg-configure for mpc, adjustments for its dependents
974c483Trac #27265: Add spkg-configure.m4 for ntl
de42045Trac #27822: Update configure tarball to include configure time checks for mpfr, mpc, and ntl

@embray
Copy link
Contributor Author

embray commented May 13, 2019

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented May 13, 2019

Branch: u/embray/build/ticket-27822

@embray
Copy link
Contributor Author

embray commented May 13, 2019

Commit: de42045

@embray

This comment has been minimized.

@embray
Copy link
Contributor Author

embray commented May 13, 2019

comment:3

It occurs to me actually that we probably can't merge any of #27258, #27259, #27265 without this ticket: Due to the changes in src/bin/sage-env-config.in Sage won't build properly anymore without an updated configure script that makes the necessary replacements in that file.

Therefore, I believe the other tickets should just be closed, and only this one merged.

@dimpase
Copy link
Member

dimpase commented May 13, 2019

comment:5

please add the last commit on #27265 :
sagemath/sagetrac-mirror@e025f88

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 17, 2019

Changed commit from de42045 to e768380

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 17, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

96a7d77correct use of AC_LINK_IFELSE
4b3caa7flint needs --with-ntl= always
e768380Trac #27822: Update configure tarball to include configure time checks for mpfr, mpc, and ntl

@embray
Copy link
Contributor Author

embray commented May 17, 2019

Updated configure

@embray
Copy link
Contributor Author

embray commented May 17, 2019

comment:7

Attachment: configure-319.tar.gz

Rebased again on #27265 and updated the configure tarball. Please double-check I didn't make any mistakes.

@dimpase
Copy link
Member

dimpase commented May 17, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented May 17, 2019

comment:8

this appears to be good.

@dimpase
Copy link
Member

dimpase commented May 18, 2019

comment:9

here one has to cherry pick the last commit from public/packages/ntlconf - the one
that adds missing quotes, namely

892143a2d89591044dc20a3c87ecccaffdd46dd7

and redo the configure tarball dance...

@vbraun
Copy link
Member

vbraun commented May 20, 2019

comment:10

configure-319 is the current confball, you always need to increment it

@vbraun
Copy link
Member

vbraun commented May 20, 2019

comment:11

Please do a full rebuild BEFORE you set any of #27258, #27259, #27265, #27822 back to positive review.

@dimpase
Copy link
Member

dimpase commented May 20, 2019

comment:12

I've rebuilt these tickets dozens of times, it's never clear w.r.t. the release process whether they will be picked in 10 minutes after they are set to positive review, or sit idle for weeks, bit-rotting.

@dimpase
Copy link
Member

dimpase commented May 20, 2019

Changed commit from e768380 to 3841611

@dimpase
Copy link
Member

dimpase commented May 20, 2019

Changed branch from u/embray/build/ticket-27822 to public/build/ticket-27822

@dimpase
Copy link
Member

dimpase commented May 20, 2019

New commits:

879dfa5add missing quotes
3841611new configure tarball

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented May 20, 2019

Changed dependencies from #27258, #27259, #27265 to none

@vbraun
Copy link
Member

vbraun commented May 22, 2019

comment:16

320 is used for 8.8.beta6, can you resolve the merge conflict and make a v321

@dimpase
Copy link
Member

dimpase commented May 22, 2019

comment:18

sure, as soon as there is a public 8.8.beta6 branch available (nether trac nor github have it)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d64963aspkg-configure for mpfr, adjustments for its dependees
5e28c6eAdd one missing SAGE_CONFIGURE_MPFR, for building gcc
32b79afTrac #27259: spkg-configure for mpc, adjustments for its dependents
b986753Trac #27265: Add spkg-configure.m4 for ntl
d7ec6abcorrect use of AC_LINK_IFELSE
7871a34flint needs --with-ntl= always
b4c6a96add missing quotes
cb88c8dnew config tarball

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2019

Changed commit from 3841611 to cb88c8d

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented May 22, 2019

comment:20

rebased over 8.8.beta6, new config tarball (version 321)

@vbraun
Copy link
Member

vbraun commented May 25, 2019

Changed branch from public/build/ticket-27822 to cb88c8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants