Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement dualRSK algorithm #28058

Closed
ChamanAgrawal opened this issue Jun 26, 2019 · 14 comments
Closed

Reimplement dualRSK algorithm #28058

ChamanAgrawal opened this issue Jun 26, 2019 · 14 comments

Comments

@ChamanAgrawal
Copy link
Member

To move the implementation of dualRSK from #25070 following the new RSK structure introduced in #27852 thereby finishing #25070.

CC: @tscrim @darijgr

Component: combinatorics

Keywords: gsocRSK

Branch/Commit: u/gh-ChamanAgrawal/28058_dualRSK @ 1bc9fb9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28058

@ChamanAgrawal
Copy link
Member Author

Last 10 new commits:

45869d9Minor documentation changes
cabc1ecAdd one-line doc and examples to functions
53ee04aAdd examples to functions
37d09deAdded simpler examples in RuleEG rev_insertion
8d339e0Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into start_dualRSK
6ced9c8Added documentation and tests for DualRSK
5313c0eChanged (rev)insertion() to single row operation
734ae02Moved rules' documentation into their class
a21d65fChange insertion function
b467c1fAdded documentation to dual RSK

@ChamanAgrawal
Copy link
Member Author

Commit: b467c1f

@ChamanAgrawal
Copy link
Member Author

Branch: u/gh-ChamanAgrawal/28058_dualRSK

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2019

Changed commit from b467c1f to 7246802

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

d5bf7deChange insertion() to reduce passing parameters
9f208c9Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into u/gh-ChamanAgrawal/28058_dualRSK
7246802Removed extra parameter from insertion()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

5cc0008Minor changes in documentation
4ee1e35Remove insertion_complete for insertion()
02db216Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into u/gh-ChamanAgrawal/28058_dualRSK
89a749cMinor change in docs and insertion()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2019

Changed commit from 7246802 to 89a749c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

f946493Add forgotten docs change
e4554eeDocs corrected
e03a2c9Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into u/gh-ChamanAgrawal/28058_dualRSK

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2019

Changed commit from 89a749c to e03a2c9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2019

Changed commit from e03a2c9 to 1bc9fb9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

1bc9fb9Resolved merge conflicts

@tscrim
Copy link
Collaborator

tscrim commented Jul 25, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 25, 2019

Changed author from Chaman Agrawal to none

@tscrim
Copy link
Collaborator

tscrim commented Jul 25, 2019

comment:6

This was reviewed in #25070.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants