Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate a few invariants commands in global namespace #28064

Closed
fchapoton opened this issue Jun 26, 2019 · 9 comments
Closed

deprecate a few invariants commands in global namespace #28064

fchapoton opened this issue Jun 26, 2019 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.9

Comments

@fchapoton
Copy link
Contributor

as part of #25383

CC: @tscrim @videlec

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 08c6973

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/28064
@fchapoton fchapoton added this to the sage-8.9 milestone Jun 26, 2019
@fchapoton
Copy link
Contributor Author

Commit: c04c12f

@fchapoton
Copy link
Contributor Author

New commits:

c04c12ftrac 28064 deprecation of some functions about invariants in global namespace

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/28064

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2019

Changed commit from c04c12f to 08c6973

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

08c6973trac 28064 add doctests for deprecations

@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@videlec
Copy link
Contributor

videlec commented Jun 27, 2019

comment:4

done

@videlec
Copy link
Contributor

videlec commented Jun 27, 2019

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Jul 5, 2019

Changed branch from u/chapoton/28064 to 08c6973

@vbraun vbraun closed this as completed in 10aecf4 Jul 5, 2019
@videlec videlec mentioned this issue Jan 7, 2023
Open
GiacomoPope added a commit to GiacomoPope/sage that referenced this issue Feb 2, 2024
@GiacomoPope
remove invariants commands in global namespace sagemath#28064
efa4c77
@GiacomoPope GiacomoPope mentioned this issue Feb 2, 2024
Merged
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 7, 2024
sagemathgh-37223: Remove invariants commands in global namespace
e232d88 
    
This PR removes the depreciated invariants from sagemath#28064 (2019). It's been
long enough and we should declutter the tab-autocomplete from these very
specific functions.

As an aside, I'm not sure why we have:

```py
from . import monsky_washnitzer
```

Instead of importing objects from this module, but I have not worked
with this myself so am loathed to modify this without further input from
the community.
    
URL: sagemath#37223
Reported by: Giacomo Pope
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 11, 2024
sagemathgh-37223: Remove invariants commands in global namespace
cdd42d4 
    
This PR removes the depreciated invariants from sagemath#28064 (2019). It's been
long enough and we should declutter the tab-autocomplete from these very
specific functions.

As an aside, I'm not sure why we have:

```py
from . import monsky_washnitzer
```

Instead of importing objects from this module, but I have not worked
with this myself so am loathed to modify this without further input from
the community.
    
URL: sagemath#37223
Reported by: Giacomo Pope
Reviewer(s): Frédéric Chapoton
@mantepse mantepse mentioned this issue Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @videlec