Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 fix and typos in combinatorial polyhedron #28153

Closed
fchapoton opened this issue Jul 10, 2019 · 11 comments
Closed

py3 fix and typos in combinatorial polyhedron #28153

fchapoton opened this issue Jul 10, 2019 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.9

Comments

@fchapoton
Copy link
Contributor

lgtm

CC: @kliem @tscrim @videlec

Component: python3

Author: Frédéric Chapoton

Branch/Commit: f57bce1

Reviewer: Jonathan Kliem, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28153
@fchapoton fchapoton added this to the sage-8.9 milestone Jul 10, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/28153

@fchapoton
Copy link
Contributor Author

New commits:

f57bce1py3 fix and typos in combinatorial polyhedron

@fchapoton
Copy link
Contributor Author

Commit: f57bce1

@kliem
Copy link
Contributor

kliem commented Jul 10, 2019

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jul 10, 2019

comment:2

Looks good to me, but I haven't pulled and tested it on a computer yet.

@fchapoton
Copy link
Contributor Author

comment:4

green bot, please review

@dimpase
Copy link
Member

dimpase commented Jul 10, 2019

Changed reviewer from Jonathan Kliem to Jonathan Kliem, Dima Pasechnik

@dimpase

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

comment:6

and there are many other typos in all this new stuff about combinatorial polyhedra...

@kliem
Copy link
Contributor

kliem commented Jul 11, 2019

comment:7

I believe it. I find it hard to detect my own typos. It took be a while to find the mistakes corrected in this ticket (reading both lines I still couldn't detect mistakes for a while). I while correct, whatever I can.

@vbraun
Copy link
Member

vbraun commented Jul 14, 2019

Changed branch from u/chapoton/28153 to f57bce1

@vbraun vbraun closed this as completed in ac097b0 Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
4 participants
@vbraun @dimpase @fchapoton @kliem