Implement Symmetry Classes of Plane Partitions #28244

kevindilks · 2019-07-24T03:12:14Z

Create classes for the different symmetry classes of plane partitions (Cyclically symmetric, Totally Symmetric, etc.), along with methods taking elements in these symmetry classes to an object in a fundamental domain (usually an order ideal in some associated poset).

CC: @jessicapalencia @tscrim @mantepse

Component: combinatorics

Keywords: days99, IMA Coding Sprint

Author: Kevin Dilks, Spencer Cook, Jessica Striker

Branch/Commit: public/combinat/symmetry_classes_plane_partitions-28244 @ a3c1c58

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28244

The text was updated successfully, but these errors were encountered:

kevindilks · 2019-07-24T03:19:59Z

Branch: u/kdilks/SymPP

kevindilks · 2019-07-24T03:34:50Z

Commit: fd46c9a

kevindilks · 2019-07-24T03:34:50Z

comment:2

Current things to work on:

I changed all.py from being a lazy import to a regular import because I thought it might have been keeping something from working. That change will very likely be reverted once I get a chance to confirm that I was wrong.
Some of the poset/comparison structures at the beginning of various iterators can be streamlined or replaced with existing code (ie, posets.ProductOfChains is a thing, that code doesn't need to be duplicated).
Iterator code currently saves all the generated objects to a list, sorts the list, and then goes through them one at a time. Instead of adding a generated object to a list, it should just be yielded at that point, and the very last part of each iterator that iterates over the generated list can be removed.
Commented out existing code for iterating over plane partitions in a box using the SemistandardTableaux iterator with the code iterating over the my using antichain iterator on product of chains poset. Once the new code is cleaned up, the two should be compared.
Documentation and doc-tests are currently minimal/missing.
Additional methods need to be added to the various classes giving maps to order ideals in the various fundamental domains.
Would the various fundamental domains be something that we would really want added to the posets catalog ( http://doc.sagemath.org/html/en/reference/combinat/sage/combinat/posets/poset_examples.html )?

New commits:

`fd46c9a`	`A very rough initial implementation`

sagetrac-git · 2019-07-25T18:12:15Z

Branch pushed to git repo; I updated commit sha1. New commits:

`38e8b71`	`Potential class structure fix`

sagetrac-git · 2019-07-25T18:12:15Z

Changed commit from fd46c9a to 38e8b71

sagetrac-git · 2019-07-25T18:22:59Z

Changed commit from 38e8b71 to 0e10ab4

sagetrac-git · 2019-07-25T18:22:59Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0e10ab4`	`added a few more base symmetry classes`

sagetrac-git · 2019-07-25T18:48:29Z

Branch pushed to git repo; I updated commit sha1. New commits:

`241a6ca`	`Symmetry subclasses need to be based on the factory class, not the all class`
`f75ed2a`	`Symmetry classes seem to know they are finite sets now`

sagetrac-git · 2019-07-25T18:48:29Z

Changed commit from 0e10ab4 to f75ed2a

sagetrac-git · 2019-07-25T19:36:01Z

Changed commit from f75ed2a to d3a2f91

sagetrac-git · 2019-07-25T19:36:01Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d3a2f91`	`Added attribute for a PlanePartition instance that makes bounding box size of box of parent (if defined), and largest bounding box otherwise`

sagetrac-git · 2019-07-25T19:48:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1c6f7cd`	`Added import statement for cartesian product until iterator code refactored`

sagetrac-git · 2019-07-25T19:48:57Z

Changed commit from d3a2f91 to 1c6f7cd

sagetrac-git · 2019-07-26T05:52:10Z

Branch pushed to git repo; I updated commit sha1. New commits:

`97bc8dd`	`Iterator for plane partitions of fixed size implemented, beginning of documentation`

sagetrac-git · 2019-07-26T05:52:10Z

Changed commit from 1c6f7cd to 97bc8dd

sagetrac-git · 2019-07-26T14:47:46Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d010cc9`	`Output of fixed size iterator needes element constructor`

sagetrac-git · 2019-07-26T14:47:46Z

Changed commit from 97bc8dd to d010cc9

sagetrac-git · 2019-07-26T15:24:32Z

Changed commit from d010cc9 to 6213c36

sagetrac-git · 2019-07-26T15:24:32Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f1b90f0`	`Added cardinality method for fixed size using recurrence relation`
`6213c36`	`Added cardinality method for fixed size using recurrence relation`

kevindilks · 2019-07-26T15:55:19Z

Version as of 11am CST July 26

sagetrac-git · 2019-07-26T16:22:51Z

Changed commit from 6213c36 to 1190398

sagetrac-git · 2019-07-26T16:22:51Z

comment:12

Attachment: plane_partition.py.gz

Branch pushed to git repo; I updated commit sha1. New commits:

`1190398`	`Added skeleton of missing classes, organized them in standard order`

sagetrac-git · 2019-07-26T16:51:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b292277`	`changed repr methods to not all caps`
`e843a52`	`cleaned up iterator code some, fixed minor category issue`

sagetrac-git · 2019-07-26T16:51:57Z

Changed commit from 1190398 to e843a52

sagetrac-git · 2019-07-26T17:30:01Z

Branch pushed to git repo; I updated commit sha1. New commits:

`507a8f6`	`More minor iterator fixes`
`d91a333`	`more changes`

jessicapalencia · 2022-10-28T14:54:30Z

comment:60

Any update? Wondering what is left to do to finish this.

tscrim · 2022-10-29T08:18:16Z

comment:61

I think all of my comments were addressed, but I am not 100% certain from the commits. This will need a rebasing to the latest develop and any commented out code should be removed. Otherwise it should be good to go.

jessicapalencia · 2023-01-26T21:32:59Z

comment:62

Hi Travis, Can you finish this or recommend someone who could? I don't have time at the moment, or a working development version of Sage. But I have gotten some requests from Sage users for this functionality!

tscrim · 2023-01-27T02:51:04Z

Changed commit from 40842e8 to 77a5b52

tscrim · 2023-01-27T02:51:04Z

Changed branch from u/kdilks/SymPP to public/combinat/symmetry_classes_plane_partitions-28244

tscrim · 2023-01-27T02:51:04Z

comment:63

I did what I could, but it should be good to go. There are probably still some other cleanup stuff to do wrt to the code style, but it now works for me.

New commits:

`29a0c4f`	`Merge branch 'u/kdilks/SymPP' of https://github.com/sagemath/sagetrac-mirror into public/combinat/symmetry_classes_plane_partitions-28244`
`77a5b52`	`A number of reviewer changes and cleanup.`

mkoeppe · 2023-01-27T19:13:53Z

comment:64

pyright complains:

  /__w/sagetrac-mirror/sagetrac-mirror/src/sage/combinat/plane_partition.py:49:20 - error: Expected class as second argument to NewType

fchapoton · 2023-01-27T20:26:15Z

comment:65

Who asked for pyright compliance ? where is the report to be seen ?

On the other hand, the linter complains about many trailing whitespaces.
and about the documentation:

./sage/combinat/plane_partition.py:1173:1: RST214 Inline literal start-string without end-string.

mkoeppe · 2023-01-27T20:27:25Z

comment:66

It's part of the "Build & Test" workflow.

mkoeppe · 2023-01-27T21:23:34Z

comment:67

pyright is right; the file uses NewType incorrectly. https://docs.python.org/3/library/typing.html#typing.NewType

sagetrac-git · 2023-01-28T02:07:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4390f31`	`Removed NewType and other small fixes.`

sagetrac-git · 2023-01-28T02:07:19Z

Changed commit from 77a5b52 to 4390f31

tscrim · 2023-01-28T02:08:26Z

comment:69

Thanks. I removed the NewType and fixed the doc error.

fchapoton · 2023-01-28T14:58:20Z

comment:71

still

./sage/combinat/plane_partition.py:3044:28: E111 indentation is not a multiple of 4
19
./sage/combinat/plane_partition.py:3136:1: W391 blank line at end of file

sagetrac-git · 2023-01-29T12:18:12Z

Changed commit from 4390f31 to a3c1c58

sagetrac-git · 2023-01-29T12:18:12Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a3c1c58`	`Fixing pycodestyle.`

tscrim · 2023-01-29T12:20:33Z

comment:73

This should take care of those.

Implement symmetric classes on plane partitions #28244 URL: #35037 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton

kevindilks mannequin added this to the sage-8.9 milestone Jul 24, 2019

kevindilks mannequin added c: combinatorics labels Jul 24, 2019

kevindilks mannequin self-assigned this Jul 26, 2019

tscrim added s: needs review and removed s: needs work labels Jan 27, 2023

mkoeppe added s: needs work and removed s: needs review labels Jan 27, 2023

tscrim added s: needs review and removed s: needs work labels Jan 28, 2023

mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023

tscrim mentioned this issue Feb 9, 2023

Implement symmetry classes of plane partitions #35037

Merged

mkoeppe added s: needs work and removed s: needs review labels Feb 13, 2023

vbraun pushed a commit that referenced this issue Apr 1, 2023

gh-35037: Implement symmetry classes of plane partitions

e380758

Implement symmetric classes on plane partitions #28244 URL: #35037 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton

tscrim removed the s: needs work label Apr 25, 2023

tscrim closed this as completed Apr 25, 2023

Implement Symmetry Classes of Plane Partitions #28244

Implement Symmetry Classes of Plane Partitions #28244

Comments

kevindilks mannequin commented Jul 24, 2019

kevindilks mannequin commented Jul 24, 2019

kevindilks mannequin commented Jul 24, 2019

kevindilks mannequin commented Jul 24, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 25, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

kevindilks mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

sagetrac-git mannequin commented Jul 26, 2019

jessicapalencia mannequin commented Oct 28, 2022

tscrim commented Oct 29, 2022

jessicapalencia mannequin commented Jan 26, 2023

tscrim commented Jan 27, 2023

tscrim commented Jan 27, 2023

tscrim commented Jan 27, 2023

mkoeppe commented Jan 27, 2023

fchapoton commented Jan 27, 2023

mkoeppe commented Jan 27, 2023

mkoeppe commented Jan 27, 2023

sagetrac-git mannequin commented Jan 28, 2023

sagetrac-git mannequin commented Jan 28, 2023

tscrim commented Jan 28, 2023

fchapoton commented Jan 28, 2023

sagetrac-git mannequin commented Jan 29, 2023

sagetrac-git mannequin commented Jan 29, 2023

tscrim commented Jan 29, 2023