Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metaticket - improvements to the Macaulay2 interface #28573

Open
saliola opened this issue Oct 7, 2019 · 19 comments
Open

Metaticket - improvements to the Macaulay2 interface #28573

saliola opened this issue Oct 7, 2019 · 19 comments

Comments

@saliola
Copy link

saliola commented Oct 7, 2019

"There are too many changes going on at once, so that a merge in the end might be difficult. In order to avoid such difficulties and to keep an overview of things that are happening (for me and others), I use this ticket from now on as a metaticket, where all latest changes are merged together." (copied from #28519).

Tickets:

CC: @saliola @dimpase @antonleykin

Component: interfaces: optional

Keywords: macaulay2, IMA Coding Sprint

Branch/Commit: public/interfaces/m2/28573 @ 1368231

Issue created by migration from https://trac.sagemath.org/ticket/28573

@saliola saliola added this to the sage-9.0 milestone Oct 7, 2019
@saliola

This comment has been minimized.

@saliola

This comment has been minimized.

@saliola

This comment has been minimized.

@saliola
Copy link
Author

saliola commented Oct 7, 2019

Commit: db63b5f

@saliola
Copy link
Author

saliola commented Oct 7, 2019

comment:4

I created a branch that merges all the tickets together to see if there was any merge conflict. There was one, but it was easy to resolve.


Last 10 new commits:

1a873f7Merge remote-tracking branch 'origin/public/interfaces/m2/macaulay2_init' into m2_quotient_rings
6e734c6conversion of quotient rings to macaulay2 & improvements to conversion of ideals
6a537c828572: fix conversion of quotient rings from Macaulay2 to Sage
5ddbe5cmark m2 doctests as optional
4b256a1add _macaulay2_init_ method to QuotientRingElement
d1566e5correct inaccuracy in doctest description
bd06a80properly handle conversion of quotient ring elements & inherit variable names when converting from M2 quotient rings
ec1773edisable caching of M2 conversion of polynomials in quotient rings (change _macaulay2_init_ to _macaulay2_)
25afa2fsimplify doctest
db63b5fMerge remote-tracking branch 'origin/public/interfaces/m2/m2_quotient_rings' into m2-metaticket

@saliola
Copy link
Author

saliola commented Oct 7, 2019

Branch: public/interfaces/m2/28573

@saliola

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

af595de28574: construct Macaulay2 polynomial rings over arbitrary base rings
e85472028574: fix conversion of polynomials to M2
49d5c0b28574: convert elements of nested polynomial rings from M2 to sage
35d4205Merge remote-tracking branch 'trac/u/gh-mwageringel/28574' into m2-metaticket

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2019

Changed commit from db63b5f to 35d4205

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2019

Changed commit from 35d4205 to d870598

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

00c028f28567: add missing optional doctest flag
1ab09eaMerge commit '00c028f94219dd8f5fbc68f566027ae1e80' into m2-metaticket
19d999528572: remove unnecessary doctests
d870598Merge commit '19d9995883416aa73f370904c8cc2' into m2-metaticket

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 10, 2019

Changed commit from d870598 to 1368231

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 10, 2019

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

15d35e3Merge remote-tracking branch 'origin/public/interfaces/m2/f4etc' into public/interfaces/m2/m2_quotient_rings
14dadd0Merge remote-tracking branch 'origin/public/interfaces/m2/m2_quotient_rings' into m2-metaticket
af595de28574: construct Macaulay2 polynomial rings over arbitrary base rings
e85472028574: fix conversion of polynomials to M2
49d5c0b28574: convert elements of nested polynomial rings from M2 to sage
23b2bf4add "optional - macaulay2" flag to doctests
0c1e001Merge remote-tracking branch 'origin/public/interfaces/m2/28566' into public/interfaces/m2/28574
72abe24finish merging
a312b15Merge branch 'public/interfaces/m2/m2_quotient_rings' into public/interfaces/m2/28574
1368231Merge remote-tracking branch 'origin/public/interfaces/m2/28574' into m2-metaticket

@saliola

This comment has been minimized.

@mwageringel

This comment has been minimized.

@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:12

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Apr 14, 2020

comment:13

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Feb 13, 2021

comment:15

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants