New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversion of nested polynomial rings to Macaulay2 #28574
Comments
Branch: u/gh-mwageringel/28574 |
Commit: |
New commits:
|
Author: Markus Wageringel |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/gh-mwageringel/28574 to public/interfaces/m2/28574 |
comment:4
reviewer name missing |
Reviewer: Franco Saliola |
comment:5
Thanks. |
Work Issues: Fix merge conflicts with #28566 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Changed work issues from Fix merge conflicts with #28566 to none |
comment:10
In order to make this ticket merge cleanly with some of the other M2 tickets summarized at #28573, I set dependencies and merged the appropriate branches. Provided the dependencies are respected, everything should merge cleanly now. |
comment:11
I am happy with this ticket. Markus, if you accept the proposed merging, then you can set this to positive review. |
Work Issues: rebase on #28572 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
comment:14
I have replaced the last merge commit by a new merge with #28572 and still all tests pass on my end. Franco, please review the merging, though maybe wait for the next beta to see if it merges cleanly. |
Changed work issues from rebase on #28572 to none |
Changed reviewer from Franco Saliola to Franco Saliola, Dima Pasechnik |
comment:15
seems to be merging just fine (with 9.0.beta4) |
Changed branch from public/interfaces/m2/28574 to |
This ticket implements conversion to and from Macaulay2 of polynomial rings over arbitrary base rings – nested polynomial rings in particular – as well as their elements.
This ticket also implements
_macaulay2_()
for polydicts. This is used in elements of nested polynomial rings, for example.It also fixes an issue where constant polynomials are accidentally converted to elements of the base ring in Macaulay2, not to elements of the polynomial ring.
We add a special case in the conversion of Galois fields, since in Macaulay2 it is more natural to define finite fields as
ZZ/p
rather thanGF p
. This has a positive effect on performance, and simplifies the construction of Macaulay2 polynomial rings.Depends on #28566
Depends on #28571
Depends on #28572
Depends on #28074
CC: @saliola @dimpase @antonleykin
Component: interfaces: optional
Keywords: macaulay2, IMA Coding Sprint
Author: Markus Wageringel
Branch/Commit:
ac2ff35
Reviewer: Franco Saliola, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/28574
The text was updated successfully, but these errors were encountered: