-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement polynomial factorization over universal cyclotomic field #28631
Comments
comment:2
I add an implementation of New commits:
|
Commit: |
comment:3
LGTM. |
Reviewer: Travis Scrimshaw |
comment:4
Thanks! |
Changed branch from u/soehms/factorization_universal_cycl_field_28631 to |
comment:6
What is your code supposed to do!?
But there is a square root
I propose to simply revert all of what this ticket did in #28659. Note that the
Please be more careful with your code submissions and reviews. Code discussion is very welcome on sage-devel and sage-nt. |
Changed commit from |
comment:7
Replying to @videlec:
I'm sorry for that, Vincent, and will be more careful in future! I didn't become aware, that there was a serious reason that this was not implemented. On the other hand, I think there are reasons, that Sage should be able to find roots of unity over the UCF. At least the following two:
My code can be easily improved (adding two lines), in order to be not vastly any more. I will explain this in the new ticket. |
Indeed, that hasn't been done so far:
CC: @tscrim
Component: number fields
Keywords: universal cyclotomic field, factorization
Author: Sebastian Oehms
Branch:
a3c9a81
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/28631
The text was updated successfully, but these errors were encountered: