Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[witch patch] allow load_files parameter in __call__ #2867

Closed
yqiang mannequin opened this issue Apr 9, 2008 · 4 comments
Closed

[witch patch] allow load_files parameter in __call__ #2867

yqiang mannequin opened this issue Apr 9, 2008 · 4 comments
Assignees
@yqiang
Labels
c: dsage p: major / 3 t: bug
Milestone
sage-3.0

Comments

@yqiang
Copy link
Mannequin

yqiang mannequin commented Apr 9, 2008

This patch allows you to do dsage('f = Foo()', load_files = ['foo.py']) which loads foo.py before executing the job.

Component: dsage

Issue created by migration from https://trac.sagemath.org/ticket/2867
@yqiang yqiang mannequin added this to the sage-3.0 milestone Apr 9, 2008
@yqiang yqiang mannequin added c: dsage labels Apr 9, 2008
@yqiang yqiang mannequin self-assigned this Apr 9, 2008
@yqiang yqiang mannequin added the s: needs review label Apr 9, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 10, 2008

comment:1

Patch looks good to me. Positive review.

For the record: Please post proper mercurial patches in the future. I.e. use export instead of diff. I cannot tell the difference with patch preview and by the time I import the patch it is too late.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 10, 2008

comment:2

Merged in Sage 3.0.alpha4

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 10, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin reopened this Apr 10, 2008
@yqiang
Copy link
Mannequin Author

yqiang mannequin commented Apr 10, 2008

Attachment: load_files.patch.gz

Attachment: load_files.2.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 10, 2008

comment:3

Oh, the irony that I didn't catch this doctest failure: Merged load_files.2.patch in Sage 3.0.alpha4.

Cheers,

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yqiang yqiang

Labels
c: dsage p: major / 3 t: bug
Projects
None yet
Milestone
sage-3.0
Development

No branches or pull requests
0 participants