Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector Bundles: Section Module Name Fix #28690

Closed
DeRhamSource mannequin opened this issue Nov 2, 2019 · 12 comments
Closed

Vector Bundles: Section Module Name Fix #28690

DeRhamSource mannequin opened this issue Nov 2, 2019 · 12 comments
Labels
c: geometry p: minor / 4 t: bug
Milestone
sage-9.0

Comments

@DeRhamSource
Copy link
Mannequin

DeRhamSource mannequin commented Nov 2, 2019

In case of smooth vector bundles, the LaTeX output of the section module leaded to C^+ Infinity(M;E) which is certainly unwanted.

CC: @egourgoulhon

Component: geometry

Keywords: vector bundles

Author: Michael Jung

Branch/Commit: 6bc2551

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28690
@DeRhamSource DeRhamSource mannequin added this to the sage-9.0 milestone Nov 2, 2019
@DeRhamSource DeRhamSource mannequin added the p: major / 3 label Nov 2, 2019
@DeRhamSource
Copy link
Mannequin Author

DeRhamSource mannequin commented Nov 2, 2019

Branch: u/gh-DeRhamSource/vector_bundles__section_module_name_fix

@DeRhamSource

This comment has been minimized.

Sign in to view
@DeRhamSource
Copy link
Mannequin Author

DeRhamSource mannequin commented Nov 2, 2019

Commit: 93b8bd3

@DeRhamSource
Copy link
Mannequin Author

DeRhamSource mannequin commented Nov 2, 2019

New commits:

93b8bd3LaTeX output fixed

@DeRhamSource
Copy link
Mannequin Author

DeRhamSource mannequin commented Nov 2, 2019

Author: Michael Jung

@DeRhamSource
Copy link
Mannequin Author

DeRhamSource mannequin commented Nov 2, 2019

Changed keywords from none to vector bundles

@DeRhamSource DeRhamSource mannequin added c: geometry and removed p: major / 3 labels Nov 2, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2019

Changed commit from 93b8bd3 to 6bc2551

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6bc2551Fix of the LaTeX fix

@DeRhamSource
Copy link
Mannequin Author

DeRhamSource mannequin commented Nov 2, 2019

comment:6

That was too eager and too fast.

Sorry for the mistake in the first place.

@tscrim
Copy link
Collaborator

tscrim commented Nov 4, 2019

comment:7

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Nov 4, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 7, 2019

Changed branch from u/gh-DeRhamSource/vector_bundles__section_module_name_fix to 6bc2551

@vbraun vbraun closed this as completed in 9296d51 Nov 7, 2019
@egourgoulhon egourgoulhon mentioned this issue Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
2 participants
@vbraun @tscrim