Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix in totallyreal_rel #2879

Closed
jvoight opened this issue Apr 11, 2008 · 5 comments
Closed

Bug fix in totallyreal_rel #2879

jvoight opened this issue Apr 11, 2008 · 5 comments
Assignees
@craigcitro
Labels
c: number theory p: major / 3 t: bug
Milestone
sage-3.0

Comments

@jvoight
Copy link

jvoight commented Apr 11, 2008

There was an bug in the enumeration of relative totally real fields: if the extension was constant (coming from Q), it was ignored by a resultant calculation. Also, some exceptional cases were unintentionally ignored. The fix is attached.

Component: number theory

Issue created by migration from https://trac.sagemath.org/ticket/2879
@jvoight jvoight added this to the sage-3.0 milestone Apr 11, 2008
@jvoight
Copy link
Author

jvoight commented Apr 11, 2008

Attachment: 8681.patch.gz

@jvoight
Copy link
Author

jvoight commented Apr 11, 2008

Attachment: 8682.patch.gz

Attachment: 8683.patch.gz

@craigcitro
Copy link
Member

comment:1

Patch looks good. I'm attaching a new version of the patch, since I had merge troubles.

@craigcitro
Copy link
Member

Attachment: trac-2879.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 15, 2008

comment:2

Merged trac-2879.patch in Sage 3.0.alpha5

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 15, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigcitro craigcitro

Labels
c: number theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-3.0
Development

No branches or pull requests
2 participants
@craigcitro @jvoight