Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini update: Fix breakage caused by src/ext move, add 32-bit linux environments and other architectures supported by docker #29143

Closed
mkoeppe opened this issue Feb 2, 2020 · 35 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Feb 2, 2020

#29053 added tox.ini to support testing the sage distribution in isolated environments via docker.

In 9.1.beta6, the generated docker files do not work due to #21785.

This ticket fixes it and also adds linux environments for various other architectures supported by docker (see https://github.com/docker-library/official-images#architectures-other-than-amd64).

Examples:

$ tox -e docker-debian-buster-standard-i386
$ tox -e docker-ubuntu-bionic-standard-arm64
$ tox -e docker-ubuntu-bionic-minimal-armhf
$ tox -e docker-fedora-31-standard-arm64v8         # Docker for Mac only
$ tox -e docker-ubuntu-latest-standard-s390x       # Docker for Mac only

(The last two work with macOS Docker Desktop because it has binfmt_misc with qemu enabled.)

See also: https://trac.sagemath.org/wiki/ExoticPorts


Resources:

CC: @vbraun @sagetrac-tmonteil @kiwifb @dimpase

Component: porting

Author: Matthias Koeppe

Branch/Commit: 7f122bd

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/29143

@mkoeppe mkoeppe added this to the sage-9.1 milestone Feb 2, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 2, 2020

Dependencies: #29053, #29104

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 2, 2020

comment:2

on top of #29104 to avoid merge conflicts

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 2, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 2, 2020

Commit: 839d6fb

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 2, 2020

Last 10 new commits:

98edff6Add build/pkgs/gfortran/distros/fedora.txt
843ca76build/pkgs/fedora.txt: Add python3
bd6a545tox.ini: Add debian stretch, put sid last
23c6334build/pkgs/openblas/distros/arch.txt: Add lapack, cblas
fca6654tox.ini: Add toxenvs local-homebrew-macos-minimal, local-homebrew-macos-standard
e0e8a4ctox.ini [local-homebrew]: Fixup PATH, PKG_CONFIG_PATH, set LDFLAGS, CPPFLAGS; [local-direct]: New
16ca88ftox.ini: Use {envlogdir}; use ln -sf
6a1803dtox.ini [local]: First build the base-toolchain
4b72987tox.ini [local-homebrew]: Set PATH earlier and set ACLOCAL_PATH for bootstrapping
839d6fbtox.ini: Add other archs supported by docker

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Add to tox.ini some 32-bit linux environments Add to tox.ini 32-bit linux environments and other architectures supported by docker Feb 2, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 2, 2020

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

67e14cefixup for llocal

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2020

Changed commit from 839d6fb to 67e14ce

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 3, 2020

comment:7

This works on macOS because it is running everything in a virtualbox.

I haven't succeeded in getting it to work on github actions yet. last attempt: https://github.com/mkoeppe/sage/runs/422184737?check_suite_focus=true

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2141b75Merge tag '9.1.beta3' into t/29104/tox-homebrew
2b0a25etox.ini: Add other archs supported by docker
e3f832cfixup for llocal
b5361e2tox.ini: Restructure docker image:tag construction, add multiarch for Linux Docker

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2020

Changed commit from 67e14ce to b5361e2

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 6, 2020

Changed dependencies from #29053, #29104 to #29104

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 6, 2020

comment:13

Tests run at https://github.com/mkoeppe/sage/actions/runs/35630769

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

4350d0atox.ini: Add raspbian

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2020

Changed commit from b5361e2 to 4350d0a

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 10, 2020

comment:16

Also this ticket needs review and would facilitate testing on 32bit x86 and ARM

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

59e1d6fMerge tag '9.1.beta4' into t/29143/add_to_tox_ini_some_32_bit_linux_environments

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2020

Changed commit from 4350d0a to 59e1d6f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

4eb201bMerge tag '9.1.beta4' into t/29104/tox-homebrew
254753dMerge branch 't/29104/tox-homebrew' into t/29143/add_to_tox_ini_some_32_bit_linux_environments

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2020

Changed commit from 59e1d6f to 254753d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2020

Changed commit from 254753d to 7f122bd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

749f83etox.ini: Add other archs supported by docker
e941bd5fixup for llocal
2441fe9tox.ini: Restructure docker image:tag construction, add multiarch for Linux Docker
2f057cbtox.ini: Add raspbian
7f122bdbuild/bin/write-dockerfile.sh: src/ext has moved and is no longer needed for the configure phase

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 2, 2020

Changed dependencies from #29104 to none

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 2, 2020

comment:20

The branch is no longer on top of #29104 (homebrew).

Needs review.

@mkoeppe mkoeppe changed the title Add to tox.ini 32-bit linux environments and other architectures supported by docker tox.ini update: Fix breakage caused by src/ext move, add 32-bit linux environments and other architectures supported by docker Mar 2, 2020
@vbraun
Copy link
Member

vbraun commented Mar 2, 2020

Reviewer: Volker Braun

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 2, 2020

comment:22

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 3, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants