calculus -- substitution of a dict for SymbolicFunctionEvaluation is broken (but **kwds works)

[williamstein]

Substitution with a dictionary as input is broken. Notice below in the
third input that the dictionary is ignored?!

sage: function('f',x)
f(x)
sage: (f(x)).substitute(f=log)
log(x)
sage: (f(x)).substitute({f:log})
f(x)
sage: type(f(x))
<class 'sage.calculus.calculus.SymbolicFunctionEvaluation'>
sage: (x^3 + 1).substitute(x=5)
126
sage: (x^3 + 1).substitute({x:5})
126

Component: calculus

Issue created by migration from https://trac.sagemath.org/ticket/2933

[mwhansen]

comment:1

Attachment: 2933.patch.gz

[ncalexan]

comment:2

I find the business with isinstance(str) strange, but it looks right and the doctests assert the correct behaviour.

[sagetrac-mabshoff]

comment:3

Merged in Sage 3.0.alpha6