qepcad build fails on slackware-14.2-maximal

[mkoeppe]

https://github.com/mkoeppe/sage/runs/612693004

g++ -O3 -g -Wl,-rpath,/sage/local/lib -I/sage/local/lib/saclib/include  -I. saclib/GCSI.c saclib/FAIL.c \
  qepcad.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/sfext/sfexto.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/lift2D/lift2Do.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/newadj/newadjo.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/adj2d/adj2do.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/rend/rendo.a /sage/local/lib/saclib/lib/saclibo.a -lreadline -lrt  qepcad.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/sfext/sfexto.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/lift2D/lift2Do.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/newadj/newadjo.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/adj2d/adj2do.a /sage/local/var/tmp/sage/build/qepcad-B.1.72/src/extensions/rend/rendo.a /sage/local/lib/saclib/lib/saclibo.a -lreadline -lrt  -o qepcad
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `tgetnum'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `tgetent'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `tgetstr'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `tgoto'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `UP'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `BC'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `tputs'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `PC'
/usr/lib64/gcc/x86_64-slackware-linux/5.5.0/../../../../lib64/libreadline.so: undefined reference to `tgetflag'
collect2: error: ld returned 1 exit status

To try: docker run -it docker.pkg.github.com/mkoeppe/sage/sage-docker-slackware-14.2-maximal-with-targets-optional:9.1.rc0-66177-gcf8d125574

CC: @dimpase

Component: packages: optional

Reviewer: Matthias Koeppe, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/29573

[mkoeppe]

comment:3

Looks like libreadline is underlinked on slackware

sh-4.3# ldd /usr/lib64/libreadline.so*
/usr/lib64/libreadline.so:
	linux-vdso.so.1 (0x00007ffc743df000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f2303446000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f2303a58000)
/usr/lib64/libreadline.so.5:
	linux-vdso.so.1 (0x00007fff86f96000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f58cbdde000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f58cc3e5000)
/usr/lib64/libreadline.so.5.2:
	linux-vdso.so.1 (0x00007ffe4a7db000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f7b24b17000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f7b2511e000)
/usr/lib64/libreadline.so.6:
	linux-vdso.so.1 (0x00007ffd00ff8000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f40c3854000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f40c3e66000)
/usr/lib64/libreadline.so.6.3:
	linux-vdso.so.1 (0x00007fffb9253000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f1818931000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f1818f43000)
sh-4.3# ls /usr/lib64/libreadline.*  
/usr/lib64/libreadline.so  /usr/lib64/libreadline.so.5	/usr/lib64/libreadline.so.5.2  /usr/lib64/libreadline.so.6  /usr/lib64/libreadline.so.6.3
sh-4.3# ls -l /usr/lib64/libreadline.*
lrwxrwxrwx 1 root root     16 Apr 23 17:05 /usr/lib64/libreadline.so -> libreadline.so.6
lrwxrwxrwx 1 root root     18 Mar 29  2019 /usr/lib64/libreadline.so.5 -> libreadline.so.5.2
-rwxr-xr-x 1 root root 249328 Aug 15  2015 /usr/lib64/libreadline.so.5.2
lrwxrwxrwx 1 root root     18 Apr 23 17:05 /usr/lib64/libreadline.so.6 -> libreadline.so.6.3
-rwxr-xr-x 1 root root 291680 Nov  7  2015 /usr/lib64/libreadline.so.6.3
sh-4.3# nm -D /usr/lib64/libreadline.so.5 | grep tgetnum
                 U tgetnum
sh-4.3# nm -D /usr/lib64/libreadline.so.6 | grep tgetnum
                 U tgetnum
sh-4.3# nm -D /usr/lib64/libncurses | grep tgetnum
libncurses++.so       libncurses++.so.5     libncurses++.so.5.9   libncurses++w.so      libncurses++w.so.5    libncurses++w.so.5.9  libncurses.so         libncurses.so.5       libncursesw.so        libncursesw.so.5
sh-4.3# nm -D /usr/lib64/libncurses | grep tgetnum
libncurses++.so       libncurses++.so.5     libncurses++.so.5.9   libncurses++w.so      libncurses++w.so.5    libncurses++w.so.5.9  libncurses.so         libncurses.so.5       libncursesw.so        libncursesw.so.5
sh-4.3# nm -D /usr/lib64/libncurses.so | grep tgetnum
000000000002fe70 T tgetnum

[dimpase]

comment:4

Is there pkg-config support for readline on Slackware, and if yes, does it correctly list libs ot link against?

[mkoeppe]

comment:5

Neither a .pc file nor a .la file

[dimpase]

comment:6

OK, so this is underlinking that needs to be tested in readline's spkg-configure. And the name of the library has to be found from ac_cv_search_wresize set by AC_SEARCH_LIBS in ncurses' spkg-configure, or the result of pkg-config --libs ncurses (this to be done on #29000).

[dimpase]

comment:7

Do we already have a ready to use docker image with Sage on Slackware, or this is still not complete?

[mkoeppe]

comment:8

Yes, see ticket description for the command line for pulling it!

[dimpase]

comment:9

$ docker run -it docker.pkg.github.com/mkoeppe/sage/sage-docker-slackware-14.2-maximal-with-targets-optional:9.1.rc0-66177-gcf8d125574
Unable to find image 'docker.pkg.github.com/mkoeppe/sage/sage-docker-slackware-14.2-maximal-with-targets-optional:9.1.rc0-66177-gcf8d125574' locally
docker: Error response from daemon: Get https://docker.pkg.github.com/v2/mkoeppe/sage/sage-docker-slackware-14.2-maximal-with-targets-optional/manifests/9.1.rc0-66177-gcf8d125574: no basic auth credentials.

[mkoeppe]

comment:10

From the doc added:

+The ``docker`` workflows automatically push images to
+``docker.pkg.github.com``.  You find them in the Packages tab of your
+GitHub repository.
+
+In order to pull them for use on your computer, you need to first
+visit https://github.com/settings/tokens/new to generate a Personal
+Access Token providing the ``read:packages`` scope.  Then log in using
+your GitHub user name and the Personal Access Token::
+
+  $ docker login docker.pkg.github.com
+
+Now you can pull the image and run it::
+
+  $ docker pull docker.pkg.github.com/mkoeppe/sage/sage-docker-fedora-31-standard-configured:f4bd671
+  $ docker run -it docker.pkg.github.com/mkoeppe/sage/sage-docker-fedora-31-standard-configured:f4bd671 bash

[mkoeppe]

comment:11

(from #29530)

[dimpase]

comment:12

No idea what to do with that GH token, it's not clear where is has to go, whether one need an external helper to deal with credential store etc. A bloody mess...

Could it be that you have not authorised 3rd parties to pull that image?

[dimpase]

comment:13

I can log in to docker with my login and password. I have no idea what "log in using
your GitHub user name and the Personal Access Token" entails. That token has to go somewhere, but where?

[mkoeppe]

comment:14

I used docker login docker.pkg.github.com --username mkoeppe --password-stdin

[mkoeppe]

comment:15

Replying to @dimpase:

Could it be that you have not authorised 3rd parties to pull that image?

No, I think this is public

[dimpase]

comment:16

dimpase@penguin:~/sage$ docker login docker.pkg.github.com
Authenticating with existing credentials...
WARNING! Your password will be stored unencrypted in /home/dimpase/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
dimpase@penguin:~/sage$ docker pull docker.pkg.github.com/mkoeppe/sage/sage-docker-slackware-14.2-maximal-with-targets-optional:9.1.rc0-66177-gcf8d125574
Error response from daemon: unauthorized: Your request could not be authenticated by the GitHub Packages service. Please ensure your access token is valid and has the appropriate scopes configured.

[mkoeppe]

comment:17

And your "existing credentials" are the new Personal Access Token?

[mkoeppe]

comment:18

Otherwise please try again with docker login docker.pkg.github.com --username dimpase --password-stdin and paste your PAT

[dimpase]

comment:19

Replying to @mkoeppe:

Otherwise please try again with docker login docker.pkg.github.com --username dimpase --password-stdin and paste your PAT

they are not new, but I don't get the logic of getting a new PAT, the relationship between GH and docker is totally opaque....

[mkoeppe]

comment:20

github is running its own docker registry, which I use here instead of DockerHub

[mkoeppe]

comment:21

I don't get either why authentication is necessary to access a public resource, but that's a fact

[dimpase]

comment:22

$ docker login docker.pkg.github.com
username: dimpase
password: <pasted PAT>

...
Login Succeeded
$ docker pull docker.pkg.github.com/mkoeppe/sage/sage-docker-slackware-14.2-maximal-with-targets-optional:9.1.rc0-66177-gcf8d125574
Error response from daemon: unauthorized: Your token has not been granted the required scopes to execute this query. The 'name' field requires one of the following scopes: ['read:packages'], but your token has only been granted the: [''] scopes. Please modify your token's scopes at: https://github.com/settings/tokens.

[dimpase]

comment:23

By the way, docker login docker.pkg.github.com with --username etc never gave me a prompt. (This is on Debian buster).

[dimpase]

comment:24

Please add something about the need to Select scopes (and the correct ones) while creating/updating GH PAT. (We're reviewing #29530 here :-))

after this change, I am able to docker pull, at least.

[mkoeppe]

comment:25

So you succeeded after selecting the scopre read:packages? Or something else?

[dimpase]

comment:26

Yes, I was able to pull and run the container.

[dimpase]

comment:30

As a fixup, we can remove

build/pkgs/readline/distros/slackware.txt

[dimpase]

comment:31

or we can add a check that system readline is not underlinked.

[dimpase]

comment:32

Replying to @dimpase:

or we can add a check that system readline is not underlinked.

I tried this with AC_SEARCH_LIBS, but I'm getting

configure:16165: checking for library containing tgetnum
configure:16196: gcc -o conftest -g -O2    conftest.c -lreadline -lcurl -lcliquer -lbz2 -lflint -l
mpfr -lgmp -lm  -lntl >&5
/usr/bin/ld: /tmp/ccm3Jhhm.o: undefined reference to symbol 'tgetnum@@NCURSES6_TINFO_5.0.19991023'
/usr/bin/ld: //lib/x86_64-linux-gnu/libtinfo.so.6: error adding symbols: DSO missing from command 
line

not sure what this is.

[mkoeppe]

comment:33

Try adding -ltinfo?

[dimpase]

comment:34

but this is meant to test whether libreadline is linked with libtinfo...

[mkoeppe]

comment:35

Don't you just need to test whether linking a test program with -lreadline works, and whether linking it with -lreadline -ltinfo works?

[dimpase]

comment:36

Replying to @mkoeppe:

Don't you just need to test whether linking a test program with -lreadline works,

but this succeeds on slackware - after all this is what AC_SEARCH_LIBS is doing.

Perhaps the test already has tinfo in LIBS?

and whether linking it with -lreadline -ltinfo works?

[mkoeppe]

comment:37

Are you still working on this?

[mkoeppe]

comment:40

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

[mkoeppe]

comment:44

We no longer support this platform, should close

[slel]

Reviewer: Matthias Koeppe, Samuel Lelièvre