Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configure's recommendations #29586

Open
slel opened this issue Apr 26, 2020 · 14 comments
Open

Improve configure's recommendations #29586

slel opened this issue Apr 26, 2020 · 14 comments

Comments

@slel
Copy link
Member

slel commented Apr 26, 2020

Dependencies, e.g. PPL for GLPK

On macOS with ppl installed via Homebrew,
the configure script reported the following:

## ---------------------------------------------------- ##
## Checking whether SageMath should install SPKG ppl... ##
## ---------------------------------------------------- ##
configure:27878: checking whether any of glpk gmp mpir
is installed as or will be installed as SPKG
configure:27882: result: yes; install ppl as well
configure:28277: no suitable system package found for SPKG ppl

and eventually recommended to brew install ppl.

It would seem that, in the above, this is correct:

configure:27878: checking whether any of glpk gmp mpir
is installed as or will be installed as SPKG
configure:27882: result: yes; install ppl as well

but this does not really follow:

configure:28277: no suitable system package found for SPKG ppl

In this case, because at least one of (glpk, gmp, mpir)
either was or would be installed as an SPKG, the script
concluded ppl should be installed as an SPKG too.

So the decision to install ppl was based on that,
not on the absence of ppl. In such a case, maybe
the script should not recommend installing ppl
(at least not without checking if it is actually there).

Initial report:
sage-release.

Python vs Python3, Python 3.7 vs Python 3.8

On macOS 10.14.6, as of July 2020, Homebrew installs Python 3.8.

Still, configure, looking for Python 3.7, recommends to brew install python3.

See also

CC: @mkoeppe @slel @mwageringel @dimpase @EmmanuelCharpentier

Component: build: configure

Issue created by migration from https://trac.sagemath.org/ticket/29586

@slel slel added this to the sage-9.2 milestone Apr 26, 2020
@slel
Copy link
Member Author

slel commented Apr 26, 2020

comment:1

To reformulate:

  • don't recommend installing a package via the system's
    package manager in case the decision to install as spkg
    was based on some dependency being installed,
    or about to be installed, as spkg

The relevant logic seems to be in m4/sage_spkg_collect.m4
or m4/sage_spkg_configure.m4.

@mkoeppe
Copy link
Member

mkoeppe commented Apr 26, 2020

comment:2

Thanks for creating the ticket! I've linked to it from #29146

@mkoeppe

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:3

I think in this case we should change build/pkgs/glpk/distros/homebrew.txt to uncomment glpk. Then its installation would be recommended, and once it's found, homebrew's ppl would be used, too.

@mkoeppe
Copy link
Member

mkoeppe commented Apr 26, 2020

comment:4

Or a bug report to homebrew should be made

@jhpalmieri
Copy link
Member

comment:5

Reporting what bug? The messages that glpk prints that we in turn filter out?

@mkoeppe
Copy link
Member

mkoeppe commented Apr 26, 2020

comment:6

Right... The comment "glpk 4.65 should not be used by Sage as long as it is not patched by Homebrew" comes from #24824.
We now (as of #29317) filter the messages out for the doctests -- but they are of course still an annoyance for users. I have not kept track of whether we have convinced any distributor to accept our GLPK patches that upstream didn't want. But we seem to be using the system package on all of arch, cygwin, debian, feora, gentoo -- so I guess with the filtered doctest messages it's good enough and we can re-enable the use of the homebrew package. I've opened #29587 for this.

@dimpase
Copy link
Member

dimpase commented Apr 26, 2020

comment:7

The main GLPK dev seems to be too busy with other things. Last time he was talking about transferring maintainership to FSF, or something like this.

@slel
Copy link
Member Author

slel commented Apr 26, 2020

comment:8

Thanks for opening and giving positive review to #29587, it's good we can use Homebrew's GLPK again.
I expanded the description at #29587 to include context and links about this GLPK issue.

The present ticket would still make sense, and is not specifically about the glpk or ppl issue.

@mkoeppe
Copy link
Member

mkoeppe commented Apr 26, 2020

comment:9

Replying to @slel:

Thanks for opening and giving positive review to #29587, it's good we can use Homebrew's GLPK again.
I expanded the description at #29587 to include context and links about this GLPK issue.

Thanks a lot.

The present ticket would still make sense, and is not specifically about the glpk or ppl issue.

I agree.

@slel

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Feb 13, 2021

comment:13

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@slel
Copy link
Member Author

slel commented Feb 26, 2021

comment:14

New related report:

@slel

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants