Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/glpk/distros/homebrew.txt: Enable glpk again #29587

Closed
mkoeppe opened this issue Apr 26, 2020 · 15 comments
Closed

build/pkgs/glpk/distros/homebrew.txt: Enable glpk again #29587

mkoeppe opened this issue Apr 26, 2020 · 15 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 26, 2020

From #29586.

In #24824 we upgraded to GLPK 4.65, released 2018-02-16.
This version of GLPK prints warning messages
"Long-step dual simplex will be used".

Many distros patch GPLK 4.65 to not print
these messages, but Homebrew does not.

[This is also
fixed in GLPK
but there has been no release of GLPK since then,
and the GLPK maintainer is currently
unable to work on it.]

Since with #29317 we ignore the warning message in doctests,
we can again use Homebrew's GLPK.

CC: @jhpalmieri @slel @dimpase @mwageringel

Component: porting

Author: Matthias Koeppe

Branch/Commit: fcee9ad

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29587

@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 26, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2020

New commits:

fcee9adbuild/pkgs/glpk/distros/homebrew.txt: Enable glpk again

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2020

Commit: fcee9ad

@dimpase
Copy link
Member

dimpase commented Apr 26, 2020

comment:4

ok

@dimpase
Copy link
Member

dimpase commented Apr 26, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2020

comment:5

Thanks!

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Apr 26, 2020

comment:7

I asked on the Homebrew Discourse about opening an issue
for fixing the Homebrew recipe for GLPK:

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 28, 2020

comment:8

Anyone else see singular segfaults with this on homebrew? https://github.com/mkoeppe/sage/runs/624792671

@mwageringel
Copy link

comment:9

I do not see those segfaults on my end, using Homebrew's GLPK.

@jhpalmieri
Copy link
Member

comment:10

Me neither. I see two doctest failures:

File "src/sage/numerical/backends/glpk_backend.pyx", line 2287, in sage.numerical.backends.glpk_backend.GLPKBackend.print_ranges
Failed example:
    p.print_ranges()
Expected:
    glp_print_ranges: optimal basic solution required
    1
Got:
    1

and

File "src/sage/libs/glpk/error.pyx", line 100, in sage.libs.glpk.error.setup_glpk_error_handler
Failed example:
    res = p.solve()
Expected:
          0: obj = ...
Got:
    <BLANKLINE>

@mwageringel
Copy link

comment:11

Yes, that is #29493.

@vbraun
Copy link
Member

vbraun commented May 2, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants