Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 2 - OptionalExtensions) #29720

Closed
mkoeppe opened this issue May 21, 2020 · 21 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 21, 2020

Follow-up from #29706.

In this part, we take care of all OptionalExtensions except for

CC: @kiwifb @dimpase @jhpalmieri @tscrim @kliem @roed314 @videlec @vbraun

Component: refactoring

Keywords: sd109

Author: Matthias Koeppe

Branch/Commit: 2821934

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29720

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 21, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented May 28, 2020

New commits:

69004cdsrc/sage: Move OptionalExtension options from src/module_list.py to distutils directives

@mkoeppe
Copy link
Member Author

mkoeppe commented May 28, 2020

Commit: 69004cd

@mkoeppe
Copy link
Member Author

mkoeppe commented May 28, 2020

Changed keywords from none to sd109

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9805a19src/sage: Move OptionalExtension options from src/module_list.py to distutils directives

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from 69004cd to 9805a19

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from 9805a19 to 401a864

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

401a864src/sage: Move OptionalExtension options (except tdlib) from src/module_list.py to distutils directives

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from 401a864 to bfd9fed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bfd9fedsrc/sage: Move OptionalExtension options (except tdlib, coxeter) from src/module_list.py to distutils directives

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 3, 2020

comment:9

fes does not really exist (it was an old-style experimental package that was never converted to new-style), but it's not the job of this ticket to remove the corresponding extension.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 3, 2020

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from bfd9fed to 2821934

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

2821934Fix sage_setup directives: Use distribution, not package

@mkoeppe

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Jun 4, 2020

comment:12

LGTM.

@kliem
Copy link
Contributor

kliem commented Jun 4, 2020

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 4, 2020

comment:13

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants