Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coxeter3: Add spkg-configure.m4, use coxeter/ prefix for includes, move OptionalExtension options to .pyx file directives #29721

Closed
mkoeppe opened this issue May 21, 2020 · 23 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 21, 2020

Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions; they install coxeter in a compatible way, i.e., headers with the prefix coxeter/.

In this ticket we change the includes in src/sage/libs/coxeter3/decl.pxd to use the prefix coxeter/, which allows us to get rid of include_dirs in src/module_list.py:

    OptionalExtension('sage.libs.coxeter3.coxeter',
              sources = ['sage/libs/coxeter3/coxeter.pyx'],
              language="c++",
              include_dirs = [os.path.join(SAGE_INC, 'coxeter')],
              package = 'coxeter3'),

This simplifies the work in #29720.

CC: @tscrim @dimpase @orlitzky @antonio-rojas @isuruf

Component: build: configure

Keywords: sd109

Author: Matthias Koeppe

Branch/Commit: 1497f3f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29721

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 21, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 27, 2020

New commits:

ad1b8b7build/pkgs/coxeter3/distros/fedora.txt: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 27, 2020

Commit: ad1b8b7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 27, 2020

Changed keywords from none to sd109

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 29, 2020

comment:5

Help with this ticket would be very welcome

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 1, 2020

Author: Matthias Koeppe, ...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

3dd2927src/module_list.py: Move OptionalExtension options for sage.libs.coxeter3.coxeter to distutils directive

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from ad1b8b7 to 3dd2927

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

dbbc985src/sage/libs/coxeter3/decl.pxd: Add coxeter/ prefix to all header includes; src/module_list.py: remove include_dirs option

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from 3dd2927 to dbbc985

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from dbbc985 to 1497f3f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6909e23build/pkgs/coxeter3/distros/fedora.txt: New
2b060aesrc/module_list.py: Move OptionalExtension options for sage.libs.coxeter3.coxeter to distutils directive
4f0d07dsrc/sage/libs/coxeter3/decl.pxd: Add coxeter/ prefix to all header includes; src/module_list.py: remove include_dirs option
1497f3fbuild/pkgs/coxeter3/spkg-configure.m4: New

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

Changed author from Matthias Koeppe, ... to Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

Changed author from Matthias Koeppe to Matthias Koeppe, ...

@mkoeppe mkoeppe changed the title spkg-configure.m4 for coxeter3 coxeter3: Add spkg-configure.m4, use coxeter/ prefix for includes, move OptionalExtension options to .pyx file directives Jun 3, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

Changed author from Matthias Koeppe, ... to Matthias Koeppe

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2020

comment:14

coxeter3 builds on my system. So LGTM.

One of these days I will actually get back to converting coxeter3 to full C++ and doing some additional cleanup...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

comment:15

Thank you!

@vbraun
Copy link
Member

vbraun commented Jun 22, 2020

Changed branch from u/mkoeppe/spkg_configure_m4_for_coxeter3 to 1497f3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants