Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interfaces doctests ready for random seeds #29967

Closed
kliem opened this issue Jun 24, 2020 · 13 comments
Closed

Make interfaces doctests ready for random seeds #29967

kliem opened this issue Jun 24, 2020 · 13 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/interfaces/

pass for different values n than just 0.

CC: @DaveWitteMorris

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: fd09637

Reviewer: Dave Morris

Issue created by migration from https://trac.sagemath.org/ticket/29967

@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

comment:1

Probably only

sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/interfaces/singular.py  # 3 doctests failed

needs to be fixed.

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Dependencies: #29962

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

comment:4
sage -t --long --random-seed=1232131238098 src/sage/interfaces/r.py
too many failed tests, not using stored timings
Running doctests with ID 2021-01-24-13-31-27-fe6ffc5b.
Git branch: develop
Using --optional=4ti2,build,debian,dochtml,e_antic,latte_int,libnauty,lidia,lrslib,mcqd,memlimit,normaliz,pip,pynormaliz,pyroaringbitmap,python_igraph,rubiks,sage,sage_spkg,speaklater,texttable
Doctesting 1 file.
R[write to console]: Warning messages:

R[write to console]: 1: 
R[write to console]: In sage10 + sage6 :
R[write to console]: 
 
R[write to console]:  longer object length is not a multiple of shorter object length

R[write to console]: 2: 
R[write to console]: In sqrt(sage10) :
R[write to console]:  NaNs produced

R[write to console]: 3: 
R[write to console]: In sqrt(sage4) :
R[write to console]:  NaNs produced

sage -t --long --random-seed=1232131238098 src/sage/interfaces/r.py
    [257 tests, 2.53 s]

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

comment:5

Replying to @kliem:

sage -t --long --random-seed=1232131238098 src/sage/interfaces/r.py
too many failed tests, not using stored timings
Running doctests with ID 2021-01-24-13-31-27-fe6ffc5b.
Git branch: develop
Using --optional=4ti2,build,debian,dochtml,e_antic,latte_int,libnauty,lidia,lrslib,mcqd,memlimit,normaliz,pip,pynormaliz,pyroaringbitmap,python_igraph,rubiks,sage,sage_spkg,speaklater,texttable
Doctesting 1 file.
R[write to console]: Warning messages:

R[write to console]: 1: 
R[write to console]: In sage10 + sage6 :
R[write to console]: 
 
R[write to console]:  longer object length is not a multiple of shorter object length

R[write to console]: 2: 
R[write to console]: In sqrt(sage10) :
R[write to console]:  NaNs produced

R[write to console]: 3: 
R[write to console]: In sqrt(sage4) :
R[write to console]:  NaNs produced

sage -t --long --random-seed=1232131238098 src/sage/interfaces/r.py
    [257 tests, 2.53 s]

I'm just going to ignore this warning. Technically, it is not a failed doctest.

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

Changed dependencies from #29962 to none

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

Commit: fd09637

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

Branch: public/29967

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2021

New commits:

fd09637Make interfaces doctests ready for random seeds

@DaveWitteMorris
Copy link
Member

comment:7

Thanks for fixing this. I tried twenty different seeds and got no doctest failures.

I don't think the warnings from r.py have anything to do with this ticket, and they are certainly not a reason to keep this ticket open. (I get them even with random-seed=0.) I opened ticket #31300 for anyone who is concerned about those warnings.

@DaveWitteMorris
Copy link
Member

Reviewer: Dave Morris

@kliem
Copy link
Contributor Author

kliem commented Jan 29, 2021

comment:8

Thank you.

@vbraun
Copy link
Member

vbraun commented Feb 20, 2021

Changed branch from public/29967 to fd09637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants