Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some flake8 cleanup in manifolds #30538

Closed
fchapoton opened this issue Sep 9, 2020 · 8 comments
Closed

some flake8 cleanup in manifolds #30538

fchapoton opened this issue Sep 9, 2020 · 8 comments
Labels
c: manifolds p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@fchapoton
Copy link
Contributor

mainly about E701 and E702 : one command per line

CC: @egourgoulhon

Component: manifolds

Author: Frédéric Chapoton

Branch/Commit: dc768e4

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/30538
@fchapoton fchapoton added this to the sage-9.3 milestone Sep 9, 2020
@fchapoton
Copy link
Contributor Author

Commit: dc768e4

@fchapoton
Copy link
Contributor Author

New commits:

dc768e4flake8 details in manifolds/ (E701 and E702)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30538

@egourgoulhon
Copy link
Member

comment:2

Thanks for taking care of this. Is the ticket ready for review?

@fchapoton
Copy link
Contributor Author

comment:3

yes, I was just waiting for a patchbot, but this takes along time

@egourgoulhon
Copy link
Member

comment:4

LGTM. The patchbot failures are not related to this ticket.

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@vbraun
Copy link
Member

vbraun commented Sep 23, 2020

Changed branch from u/chapoton/30538 to dc768e4

@vbraun vbraun closed this as completed in 82534f5 Sep 23, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.2 Sep 23, 2020
@egourgoulhon egourgoulhon mentioned this issue Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @egourgoulhon @fchapoton @mkoeppe