Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in SymmetricGroup(1).cayley_graph() #3070

Closed
sagetrac-mabshoff mannequin opened this issue May 1, 2008 · 6 comments
Closed

bug in SymmetricGroup(1).cayley_graph() #3070

sagetrac-mabshoff mannequin opened this issue May 1, 2008 · 6 comments

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 1, 2008

In https://groups.google.com/group/sage-support/browse_thread/thread/443ce49730b43396 M. Fix reported:

Hello-
I input the following:

sage: s1 = SymmetricGroup(1)
sage: s = s1.cayley_graph()
sage: s.vertices()
[]

Shouldn't the set of vertices have one element in it for the
identity?  s1 reports this element, but as shown the graph does not.
I suppose this is trivial, but it seems like it should be fixed at
some point.  I am, however, still fairly new to SAGE, and could easily
be missing something.  Any thoughts on this? 

Cheers,

Michael

Component: graph theory

Issue created by migration from https://trac.sagemath.org/ticket/3070

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.0.1 milestone May 1, 2008
@rlmill
Copy link
Mannequin

rlmill mannequin commented May 1, 2008

Attachment: trac3070-cayley_graph_constructor.patch.gz

@rlmill
Copy link
Mannequin

rlmill mannequin commented May 1, 2008

comment:1

Applied to sage-3.0 on my macbook:

$ ./sage -t devel/sage/sage/groups/
... 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 178.3 seconds
$ ./sage -t devel/sage/sage/graphs
...
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 217.6 seconds

@rlmill rlmill mannequin changed the title bug in SymmetricGroup(1).cayley_graph() [needs easy review] bug in SymmetricGroup(1).cayley_graph() May 1, 2008
@rlmill
Copy link
Mannequin

rlmill mannequin commented May 1, 2008

comment:2

Conclusion:

The function cayley_graph was unnecessarily complicated.

@jasongrout
Copy link
Member

comment:3

the patch looks good to me. I didn't apply or doctest it, though.

@jasongrout jasongrout changed the title [needs easy review] bug in SymmetricGroup(1).cayley_graph() [with patch, positive review (pending doctesting)] bug in SymmetricGroup(1).cayley_graph() May 2, 2008
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 2, 2008

comment:5

Doctests pass with the patch applied.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [with patch, positive review (pending doctesting)] bug in SymmetricGroup(1).cayley_graph() bug in SymmetricGroup(1).cayley_graph() May 2, 2008
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 2, 2008

comment:6

Merged in Sage 3.0.1.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 2, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants