Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow double-sided limit from sympy #30759

Closed
fchapoton opened this issue Oct 13, 2020 · 19 comments
Closed

allow double-sided limit from sympy #30759

fchapoton opened this issue Oct 13, 2020 · 19 comments

Comments

@fchapoton
Copy link
Contributor

Component: calculus

Keywords: limit

Author: Frédéric Chapoton

Branch/Commit: cc08650

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/30759

@fchapoton fchapoton added this to the sage-9.3 milestone Oct 13, 2020
@fchapoton
Copy link
Contributor Author

New commits:

cc08650double-sided limits are now available in sympy

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30759

@fchapoton
Copy link
Contributor Author

Commit: cc08650

@seblabbe
Copy link
Contributor

comment:2

Don't you want to add one example in the doc?

@fchapoton
Copy link
Contributor Author

comment:3

sure, but there is already a ticket about giac limits waiting : #30742

@seblabbe
Copy link
Contributor

comment:4

ok, I see

@seblabbe
Copy link
Contributor

Changed branch from u/chapoton/30759 to public/30759

@seblabbe

This comment has been minimized.

@seblabbe
Copy link
Contributor

New commits:

d77dc8fdouble-sided limits are now available in sympy
31ef15f30759: fixing pycodestyle warning (E701 multiple statements on one line (colon))

@seblabbe
Copy link
Contributor

Changed commit from cc08650 to 31ef15f

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@seblabbe
Copy link
Contributor

comment:6

I confirm that your commit fixes the issue. Bot is green except for one pycodestyle warning.

So, I added a one-line commit to fix one pycodestyle warning on top of your branch.

I also rebased your commit on top of rc3 to avoid a useless merge in the history.

Feel free to change the status to positive review if bot is totally green.

@seblabbe

This comment has been minimized.

@fchapoton
Copy link
Contributor Author

comment:7

la correction du E701 va provoquer un conflit avec #30542

mais c'est pas grave, quelqu'un se farcira le rebasage..

@seblabbe
Copy link
Contributor

comment:8

ok, alors on peut remettre u/chapoton/30759

@seblabbe
Copy link
Contributor

New commits:

cc08650double-sided limits are now available in sympy

@seblabbe
Copy link
Contributor

Changed commit from 31ef15f to cc08650

@seblabbe
Copy link
Contributor

Changed branch from public/30759 to u/chapoton/30759

@vbraun
Copy link
Member

vbraun commented Nov 1, 2020

Changed branch from u/chapoton/30759 to cc08650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants