Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of options handled in src/bin/sage and build/bin/sage-site #30979

Closed
mkoeppe opened this issue Nov 30, 2020 · 8 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 30, 2020

(from #30846)

We remove the duplication of lines like

if [ "$1" = '-optional' -o "$1" = "--optional" ]; then
    shift
    exec sage-list-packages optional $@
fi

in src/bin/sage and build/bin/sage-site.

We keep handling of the option --installed in src/bin/sage in anticipation of #30940 (src/bin/sage-list-packages: Make it work if SAGE_ROOT is not available).

CC: @jhpalmieri @seblabbe @kliem

Component: scripts

Author: Matthias Koeppe

Branch/Commit: 87dad36

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/30979

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 30, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 30, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 30, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 30, 2020

Commit: 87dad36

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 30, 2020

New commits:

87dad36src/bin/sage, build/bin/sage-site: Remove duplication of options -installed, -p, -package, -optional, -experimental, -standard

@kliem
Copy link
Contributor

kliem commented Dec 22, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Dec 22, 2020

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Dec 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants