Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move src/bin/sage-list-packages to build/bin #30846

Closed
mkoeppe opened this issue Nov 1, 2020 · 12 comments
Closed

move src/bin/sage-list-packages to build/bin #30846

mkoeppe opened this issue Nov 1, 2020 · 12 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 1, 2020

(from #30747)

We move src/bin/sage-list-packages to build/bin. It is only used in build/bin/sage-site (to implement sage --installed etc.) and not documented individually as a script.

Depends on #30865
Depends on #30940

CC: @jhpalmieri @dimpase @orlitzky @kiwifb @videlec

Component: build

Branch/Commit: u/mkoeppe/move__src_bin_sage_list_packages__to__build_bin_ @ 044fcc0

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30846

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 1, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

Commit: 044fcc0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

New commits:

044fcc0Move sage-list-packages from src/bin (sagelib) to build/bin (sage_bootstrap)

@jhpalmieri
Copy link
Member

comment:3

Why are lines like

if [ "$1" = '-optional' -o "$1" = "--optional" ]; then
    shift
    exec sage-list-packages optional $@
fi

in both src/bin/sage and build/bin/sage-site? In any case, this ticket looks like a good time to delete those from src/bin/sage, unless I'm missing something.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

comment:4

Thanks for catching this. Looks like something went wrong when resolving a merge conflict at some point.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 19, 2020

comment:5

I am changing the approach a bit and will go through #30865

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

Dependencies: #30865

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

Changed author from Matthias Koeppe to none

@mkoeppe mkoeppe removed this from the sage-9.3 milestone Nov 20, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2020

Changed dependencies from #30865 to #30865, #30940

@dimpase
Copy link
Member

dimpase commented Nov 21, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 30, 2020

comment:9

Replying to @jhpalmieri:

Why are lines like

if [ "$1" = '-optional' -o "$1" = "--optional" ]; then
    shift
    exec sage-list-packages optional $@
fi

in both src/bin/sage and build/bin/sage-site? In any case, this ticket looks like a good time to delete those from src/bin/sage, unless I'm missing something.

This is now #30979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants