Specify bdist temp folder for WSL compatibility

[tobiasdiez]

On WSL, bdist_wheel sometimes encounters strange permission errors (when the source folder is a Windows folder mounted in WSL), see pypa/packaging-problems#258. In the linked issue, a solution is described by changing the permissions for authenticated users, but it didn't work for me. Thus I've implemented the workaround mentioned in pypa/packaging-problems#258 (comment) and specified an explicit bdist directory in the Linux system.

CC: @mkoeppe

Component: build

Keywords: sd111

Author: Tobias Diez, Matthias Koeppe

Branch/Commit: fb10429

Reviewer: Matthias Koeppe, Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/31002

[mkoeppe]

comment:2

Thanks for tracking down this problem.

I don't think using ~/temp/ is a good idea, though.
I think a better solution would be to use the command mktemp -d to create a directory in the system directory for temporary files.

[sagetrac-git]

Changed commit from a8e0364 to a3077c7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a3077c7

Use mktemp

[tobiasdiez]

comment:4

ok done

[mkoeppe]

comment:5

The temporary directory should probably be removed afterwards...

Probably best to create a new function sdh_setup_bdist_wheel in build/bin/sage-dist-helpers for that

[tobiasdiez]

comment:6

Unless --keep-temp is specified, the bdist directory is cleaned up anyway. https://setuptools.readthedocs.io/en/latest/userguide/commands.html#bdist-egg-create-a-python-egg-for-the-project

[mkoeppe]

comment:7

But the directory is not removed as far as I can see

[tobiasdiez]

comment:8

Replying to @mkoeppe:

But the directory is not removed as far as I can see

Probably. If you think this is a problem, I would like to ask you to implement your suggestion with the sage-dist-helpers. My shell knowledge is sadly not good enough for this.

[mkoeppe]

comment:9

OK, will do

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c5a14a3

build/bin/sage-dist-helpers (sdh_setup_bdist_wheel): New

[sagetrac-git]

Changed commit from a3077c7 to c5a14a3

[mkoeppe]

comment:11

Replying to @mkoeppe:

But the directory is not removed as far as I can see

Actually I was wrong about this

[mkoeppe]

comment:12

Replying to @tobiasdiez:

I would like to ask you to implement your suggestion with the sage-dist-helpers.

Nevertheless I have implemented this function. Better to have it in one place.

I have only changed it in the pillow install script, where it seems to work.

Could you change the other ones?

[mkoeppe]

comment:13

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

[mkoeppe]

Changed keywords from none to sd111

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fb10429

build/pkgs/*/spkg-install.in: Use new function sdh_setup_bdist_wheel

[sagetrac-git]

Changed commit from c5a14a3 to fb10429

[mkoeppe]

Reviewer: Matthias Koeppe, ...

[mkoeppe]

Changed author from Tobias Diez to Tobias Diez, Matthias Koeppe

[mkoeppe]

comment:15

Changed the remaining ones.

[tobiasdiez]

comment:16

Thanks! LGTM

[tobiasdiez]

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Tobias Diez

[vbraun]

Changed branch from public/build/bdist_wsl to fb10429