New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@interact grid control #3121
Comments
comment:1
The current patch needs to be cleaned up and doctests fixed. I'm putting it up so that people can play with it if they want and also to backup the work. I plan to clean it up fairly soon. |
comment:2
With the updated patch, the following two examples work beautifully:
|
comment:3
REFEREE REPORT: Wow, this totally rocks! Great work! Some minor comments.
|
comment:4
The patch has been updated to address all of William's comments and is ready to be reviewed again. |
comment:5
I tried the example:
but now the defaults in the input form are all empty instead of containing |
comment:6
NEW RREFEREE EPORT:
|
comment:7
Changing the once instance of svalue to value fixes points 1 and 3 above. Just add something to the docstring for interact? and this will be done. |
comment:8
Attachment: trac-3121-input-grid.patch.gz I updated the patch again; sorry about not catching that typo (I apparently forgot to run sage -b before testing the last patch). I also added an is_Matrix check to the automatic controls, so something like:
creates the appropriate input_grid control. I made my example in interact? use that method. There are two patches above. They are identical and one can be deleted. |
this cleans up the docs a little bit and adds some consistency. apply after the other patch |
comment:9
Attachment: sage-3121-part2_doc.patch.gz I'm OK with this if Jason is ok with sage-3121-part2_doc.patch |
comment:10
Looks good to me. William's patch also fixes a few other unrelated documentation things with interact. |
comment:11
Merged both patches in Sage 3.0.2.alpha0 |
Make a grid control for
@
interactWith the patch, this is possible:
Component: notebook
Issue created by migration from https://trac.sagemath.org/ticket/3121
The text was updated successfully, but these errors were encountered: