Add package msolve 0.4.4 (multivariate polynomial system solver) #31664

mkoeppe · 2021-04-12T23:44:04Z

https://msolve.lip6.fr/index.html

Upstream issues/PRs:

Depends on #33734
Depends on #34519

Upstream: Reported upstream. No feedback yet.

CC: @dimpase @yuan-zhou @isuruf @kiwifb

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: fa77041

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/31664

The text was updated successfully, but these errors were encountered:

yuan-zhou · 2021-04-12T23:56:17Z

comment:1

https://msolve.lip6.fr/downloads/msolve-tutorial.pdf section 8 talks about their sage interface.

dimpase · 2021-04-13T14:45:12Z

comment:2

It needs to be autoconfiscated, or cmake'd - working with something that only has a Makefile is not what we do. I'll ask an author I know about their plans in this respect.

mkoeppe · 2021-06-24T16:50:24Z

comment:3

What's the status here?

dimpase · 2021-06-26T08:56:48Z

comment:4

it appears that autotools have been added, cf. https://gitlab.lip6.fr/safey/msolve

dimpase · 2021-06-26T09:17:51Z

comment:5

I was able to build on macOS Homebrew with default options (except CC and CXX, clang) and solve a test example.
Unfortunately there are still no real tests in the repo.

mezzarobba · 2022-04-20T08:50:33Z

comment:9

See also #33734 for using msolve in variety().

mkoeppe · 2022-04-25T20:27:29Z

Dependencies: #33734

mkoeppe · 2022-09-11T19:14:17Z

Author: Matthias Koeppe

mkoeppe · 2022-09-11T19:22:05Z

comment:14

Where are their source tarballs?

mkoeppe · 2022-09-11T19:24:47Z

comment:16

https://gitlab.lip6.fr/safey/msolve/-/archive/v0.4.4/msolve-v0.4.4.tar.gz is just an archive, does not contain the bootstrapped artifacts

mkoeppe · 2022-09-11T19:28:45Z

ran "./autogen.sh && ./configure && make dist"

mkoeppe · 2022-09-11T19:33:42Z

Branch: u/mkoeppe/add_package_msolve_0_2_4__multivariate_polynomial_system_solver_

mkoeppe · 2022-09-11T19:33:42Z

comment:17

Attachment: msolve-0.4.4.tar.gz

mkoeppe · 2022-09-11T19:34:05Z

comment:18

I'm getting

[msolve-0.4.4] Making all in src/neogb
[msolve-0.4.4] /usr/local/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..    -mmmx -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -maes -mavx -mfma -mavx2 -mrdrnd -mbmi -mbmi2 -madx  -g -O2 -c -o libneogb_la-gb.lo `test -f 'gb.c' || echo './'`gb.c
[msolve-0.4.4] libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -mmmx -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -maes -mavx -mfma -mavx2 -mrdrnd -mbmi -mbmi2 -madx -g -O2 -c gb.c  -fno-common -DPIC -o .libs/libneogb_la-gb.o
[msolve-0.4.4] gb.c:50:10: fatal error: 'f4sat.c' file not found
[msolve-0.4.4] #include "f4sat.c"    /* implemenation of saturation algorithm */
[msolve-0.4.4]          ^~~~~~~~~
[msolve-0.4.4] 1 error generated.
[msolve-0.4.4] make[5]: *** [libneogb_la-gb.lo] Error 1
[msolve-0.4.4] make[4]: *** [all-recursive] Error 1
[msolve-0.4.4] make[3]: *** [all] Error 2

New commits:

`d24ad0f`	`build/pkgs/msolve: New`

mkoeppe · 2022-09-11T20:01:20Z

comment:21

Attachment: msolve-0.4.4+sage-2022-09-11.tar.gz

I've created a fork in https://github.com/sagemath/msolve because the upstream gitlab instance is compartmentalized

sagetrac-git · 2022-09-11T20:07:46Z

Changed commit from d24ad0f to c2d83ec

sagetrac-git · 2022-09-11T20:07:46Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c2d83ec`	`build/pkgs/msolve: Use msolve-0.4.4+sage-2022-09-11`

mkoeppe · 2022-09-11T20:08:32Z

comment:23

Builds for me on macOS. Haven't tested anything else.

mkoeppe · 2022-09-11T20:08:32Z

Upstream: Not yet reported upstream; Will do shortly.

mkoeppe · 2022-09-11T20:09:34Z

comment:24

Can't even report an Issue in upstream's gitlab instance.
https://gitlab.lip6.fr/users/sign_in

mezzarobba · 2022-09-12T05:49:49Z

comment:25

Replying to Matthias Köppe:

Can't even report an Issue in upstream's gitlab instance.
https://gitlab.lip6.fr/users/sign_in

They have a github mirror at https://github.com/algebraic-solving/msolve which seems to accept issues.

mkoeppe · 2022-09-12T14:38:40Z

comment:26

Thanks!

mkoeppe · 2022-09-12T14:39:29Z

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

sagetrac-git · 2022-09-12T14:41:01Z

Changed commit from c2d83ec to e7ff1da

sagetrac-git · 2022-09-12T14:41:01Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e7ff1da`	`build/pkgs/msolve/SPKG.rst: Point to upstream github`

mkoeppe · 2022-09-15T19:29:29Z

Changed dependencies from #33734 to #33734, #34519

sagetrac-git · 2022-09-15T19:39:27Z

Changed commit from e7ff1da to 21c3c97

sagetrac-git · 2022-09-15T19:39:27Z

Branch pushed to git repo; I updated commit sha1. New commits:

`367b862`	`#34519 fix msolve interface`
`ea64d4a`	`#34519 msolve: real solving with ℓ > 1`
`9055d30`	`#34519 msolve: varieties over finite fields`
`1d70b04`	`#34519 msolve._variety() -> msolve.variety()`
`14fc8e7`	`#34519 _run_msolve()`
`bc01223`	`#34519 Gröbner bases using msolve`
`c298818`	`Merge #34519`
`dd08bb1`	`Link to msolve spkg page`
`21c3c97`	`src/sage/rings/polynomial/msolve.py: Use absolute filename of msolve`

mezzarobba · 2022-09-16T10:14:16Z

comment:32

Rebased everything on top of Fix + extend msolve interface #34519 because I had force-pushed there before noticing you had a branch based on it.
Did you push the tarball you created anywhere? I don't see it in the github releases of your fork, and make dist on your msolve branch does not seem to be enough to generate it.

New commits:

`d5565cf`	`#34519 msolve: varieties over finite fields`
`7b09d5d`	`#34519 msolve._variety() -> msolve.variety()`
`7db5678`	`#34519 _run_msolve()`
`e43bc6e`	`#34519 Gröbner bases using msolve`
`b5adcc9`	`#34519 update doc on msolve`
`d2cede6`	`build/pkgs/msolve: New`
`95e2e54`	`build/pkgs/msolve: Use msolve-0.4.4+sage-2022-09-11`
`e552a50`	`build/pkgs/msolve/SPKG.rst: Point to upstream github`
`91d69cc`	`Link to msolve spkg page`
`fa77041`	`src/sage/rings/polynomial/msolve.py: Use absolute filename of msolve`

mezzarobba · 2022-09-16T10:14:16Z

Changed commit from 21c3c97 to fa77041

mezzarobba · 2022-09-16T10:14:16Z

Changed branch from u/mkoeppe/add_package_msolve_0_2_4__multivariate_polynomial_system_solver_ to public/31664-msolve_package

mkoeppe · 2022-09-16T16:53:54Z

comment:33

Replying to Marc Mezzarobba:

Rebased everything on top of Fix + extend msolve interface #34519 because I had force-pushed there before noticing you had a branch based on it.

Thank you.

Did you push the tarball you created anywhere? I don't see it in the github releases of your fork

See checksums.ini.

To test, no manual action is needed. Just use ./configure --enable-download-from-upstream-url, and installing the package will download the tarball

mezzarobba · 2022-09-16T18:20:01Z

comment:34

Ok, thank you!

mkoeppe · 2022-09-16T18:23:59Z

comment:35

Thank you!

mkoeppe · 2022-09-16T18:23:59Z

Reviewer: Marc Mezzarobba

vbraun · 2022-09-27T22:32:30Z

Changed branch from public/31664-msolve_package to fa77041

mkoeppe added this to the sage-9.4 milestone Apr 12, 2021

mkoeppe added c: packages: optional labels Apr 12, 2021

mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021

mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021

mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022

mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 6, 2022

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Add package msolve (multivariate polynomial system solver)~~ Add package msolve 0.2.4 (multivariate polynomial system solver) Sep 11, 2022

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Add package msolve 0.2.4 (multivariate polynomial system solver)~~ Add package msolve 0.4.4 (multivariate polynomial system solver) Sep 11, 2022

mkoeppe added the s: needs review label Sep 11, 2022

This comment has been minimized.

Sign in to view

mezzarobba added s: positive review and removed s: needs review labels Sep 16, 2022

vbraun removed the s: positive review label Sep 27, 2022

vbraun closed this as completed in a802d07 Sep 27, 2022

This was referenced May 22, 2022

variety() for polynomial systems over ℚ using msolve #33734

Closed

Fix + extend msolve interface #34519

Closed

Add package msolve 0.4.4 (multivariate polynomial system solver) #31664

Add package msolve 0.4.4 (multivariate polynomial system solver) #31664

Comments

mkoeppe commented Apr 12, 2021

yuan-zhou commented Apr 12, 2021

dimpase commented Apr 13, 2021

mkoeppe commented Jun 24, 2021

dimpase commented Jun 26, 2021

dimpase commented Jun 26, 2021

mezzarobba commented Apr 20, 2022

mkoeppe commented Apr 25, 2022

This comment has been minimized.

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

This comment has been minimized.

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

sagetrac-git mannequin commented Sep 11, 2022

sagetrac-git mannequin commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mkoeppe commented Sep 11, 2022

mezzarobba commented Sep 12, 2022

mkoeppe commented Sep 12, 2022

This comment has been minimized.

mkoeppe commented Sep 12, 2022

sagetrac-git mannequin commented Sep 12, 2022

sagetrac-git mannequin commented Sep 12, 2022

mkoeppe commented Sep 15, 2022

sagetrac-git mannequin commented Sep 15, 2022

sagetrac-git mannequin commented Sep 15, 2022

mezzarobba commented Sep 16, 2022

mezzarobba commented Sep 16, 2022

mezzarobba commented Sep 16, 2022

mkoeppe commented Sep 16, 2022

mezzarobba commented Sep 16, 2022

mkoeppe commented Sep 16, 2022

mkoeppe commented Sep 16, 2022

vbraun commented Sep 27, 2022