Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManifoldSubset: Add methods subset_family, superset_family, open_superset_family; deprecate method list_of_subsets #31727

Closed
mkoeppe opened this issue Apr 25, 2021 · 25 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 25, 2021

Follow-up from #31718.

This ticket proposes to deprecate list_of_subsets (note - no other methods in sage.manifolds follow this naming scheme) in favor of a new method subset_family, which prints in a more compact way, is hashable, and is sorted by name too.

We also add superset_family (previously the set of supersets was not exposed by a method).

We also add open_superset_family (to complement open_superset added in #31677).

Depends on #31718
Depends on #31677

CC: @egourgoulhon @mjungmath @tscrim

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: 2b47b1b

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/31727

@mkoeppe mkoeppe added this to the sage-9.4 milestone Apr 25, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2021

Commit: 52a93f9

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2021

Last 10 new commits:

5d87ceeManifold{Object,Subset}FiniteFamily: Rename from FiniteManifold{Object,Subset}Family
2f2ace2src/doc/en/reference/manifolds/manifold.rst: Add sage.manifolds.family
1aff58aFix up docstring markup
b922066ManifoldSubsetFiniteFamily: If all subsets are open, include 'open' in repr
30271afFixup doctest
adac07aMerge #31680
78cc27aManifoldSubset.open_covers: Change to generator, add optional arg 'trivial'; update uses
e026e7aManifoldSubset.subset_digraph: Use open_covers method
3c5555aMerge #31718
52a93f9ManifoldSubset.subset_family: New; deprecate .list_of_subsets

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2021

Dependencies: #31718

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f1bc8bcManifoldSubset.superset_family: New, use it in doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2021

Changed commit from 52a93f9 to f1bc8bc

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 25, 2021

Changed dependencies from #31718 to #31718, #31677

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2021

Changed commit from f1bc8bc to 59553f7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ef1614aRefactor Manifold.open_subset methods through new method _init_open_subset
265b0e2TopologicalManifold._init_open_subset: Add docstring
a93f7edTopologicalSubmanifold._init_open_subset: Add docstring
58b43f7DifferentiableManifold._init_open_subset: Add docstring
d542412ManifoldSubset.open_supersets: New generator, use it to fix loops that assume open supersets
c821a75{Topological,...}Manifold.open_subset: New optional parameter supersets
b35eca1ManifoldSubset.{open_subset,_init_open_subset}: New
afe10a0Merge #31677
cd1fa4dManifoldSubset.open_superset_family: New
59553f7ManifoldSubset.open_cover_family: New

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title ManifoldSubset: Add methods subset_family, superset_family, equal_subset_family; deprecate method list_of_subsets ManifoldSubset: Add methods subset_family, superset_family, open_superset_family, open_cover_family; deprecate method list_of_subsets Apr 25, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

fc23784ManifoldSubset.open_cover_family: Fix up docstring

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2021

Changed commit from 59553f7 to fc23784

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d5127e5ManifoldSubset.open_cover_family: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Changed commit from fc23784 to d5127e5

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title ManifoldSubset: Add methods subset_family, superset_family, open_superset_family, open_cover_family; deprecate method list_of_subsets ManifoldSubset: Add methods subset_family, superset_family, open_superset_family; deprecate method list_of_subsets Apr 26, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Changed commit from d5127e5 to cd1fa4d

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2021

comment:13

Removed the last commit; the addition of open_cover_family will now happen in #31732 instead.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2021

comment:14

Ready for review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Changed commit from cd1fa4d to 2b47b1b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7a22bb0ManifoldSubset.superset_family: New, use it in doctests
bdc07ffMerge #31677
2b47b1bManifoldSubset.open_superset_family: New

@egourgoulhon
Copy link
Member

comment:16

LGTM. Thanks!

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@mkoeppe
Copy link
Member Author

mkoeppe commented May 2, 2021

comment:18

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants