ManifoldSubset: union, intersection, declare_{union,intersection} with arbitrary number of arguments

[mkoeppe]

In this ticket, we extend union and declare_union as follows:

• support more than two arguments
• optional argument disjoint
• support 0 arguments (declare_union is the same as declare_empty())
• support 1 argument (declare_union is the same as declare_equal(other))

Likewise, we extend declare_intersection and intersection.

We also introduce

• declare_disjoint(other) - same as self.intersection(other).declare_empty()

Depends on #31680
Depends on #31718
Depends on #31727
Depends on #31732
Depends on #31736
Depends on #31763
Depends on #31880

CC: @egourgoulhon @mjungmath

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: 582b58d

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/31764

[mkoeppe]

Branch: u/mkoeppe/manifoldsubset__union__intersection__declare__union_intersection__with_arbitrary_number_of_arguments

[mkoeppe]

Commit: a083569

[mkoeppe]

Last 10 new commits:

c776366	ManifoldSubset.intersection: Handle arbitrary intersections
fb6e66a	intersection: Refactor
b1bb1aa	ManifoldSubset.intersection: Only pass name, latex_name to the final intersection
0032bf9	ManifoldSubset.intersection: Go through ManifoldSubsetFiniteFamily to make the order of operations canonical
282010b	ManifoldSubset._union_subset: Factor out from ManifoldSubset.union
6772570	ManifoldSubset.union: Handle arbitrary unions
edfea33	ManifoldSubset.union: Add example and plots
fdd0aba	ManifoldSubset.declare_union: Handle arbitrary unions
c2f484c	src/sage/manifolds/subset.py: import itertools
a083569	ManifoldSubset._intersection_subset, _union_subset: Use declare_subset, declare_superset; fix doctest

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

da91653

ManifoldSubset._union_subset: Fixup

[sagetrac-git]

Changed commit from a083569 to da91653

[egourgoulhon]

comment:4

Doctests are missing for the methods _reduce_intersection_members, _intersection_subset, _reduce_union_members and _union_subset.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

94edd68	ManifoldSubset.declare_superset: Fix documentation
41826b4	ManifoldSubset.declare_{sub,super}set: Expand docstring
3ef5141	Merge #31763
79a625b	ManifoldSubset._reduce_intersection_members: Add examples, raise TypeError if input is empty family
8e70023	ManifoldSubset._reduce_union_members: Add examples
ee4efc9	ManifoldSubset._{union,intersection}_subset: Do cache the result here; add examples

[sagetrac-git]

Changed commit from da91653 to ee4efc9

[egourgoulhon]

comment:8

What about the Pyflakes error? (local variable 'old' is assigned to but never used)

[sagetrac-git]

Changed commit from ee4efc9 to 6bbd4ae

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

21739de	src/sage/manifolds/subset.py: Simplify code, make pyflakes happy
6bbd4ae	src/sage/manifolds/subset.py: Add coding header

[mkoeppe]

comment:10

Ready for review. The error indicated by the patchbot is unrelated to this ticket

[egourgoulhon]

comment:11

Well, pyflakes is still not happy, despite comment:9 commit.

[sagetrac-git]

Changed commit from 6bbd4ae to 2d7fda7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2d7fda7

src/sage/manifolds/subset.py: Simplify code more to make pyflakes happy

[mkoeppe]

comment:13

Indeed... thanks for your patience

[egourgoulhon]

comment:14

Sorry for the delay. LGTM. Thanks for this improvement!

[egourgoulhon]

Reviewer: Eric Gourgoulhon

[mkoeppe]

comment:15

Thank you!

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

359dde1	Merge branch 't/31727/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets' into t/31732/manifoldsubset__new_methods_declare_empty__declare_nonempty__is_empty__has_defined_points__open_cover_family
0e9e5cd	Merge #31732

[sagetrac-git]

Changed commit from 2d7fda7 to 0e9e5cd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fd4506a	Merge #31732
a96f736	Merge #31736

[sagetrac-git]

Changed commit from 0e9e5cd to a96f736

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7fed9ef	Merge #31736
c4acd09	Merge tag '9.4.beta2' into t/31763/manifoldsubset__new_methods_declare_subset__declare_superset
582b58d	Merge #31763

[sagetrac-git]

Changed commit from a96f736 to 582b58d

[mkoeppe]

comment:19

Trivial merge with updated tickets, includes latest beta.

[mkoeppe]

Changed dependencies from #31680, #31718, #31677, #31727, #31732, #31736, #31763 to #31680, #31718, #31727, #31732, #31736, #31763

[mkoeppe]

Changed dependencies from #31680, #31718, #31727, #31732, #31736, #31763 to #31680, #31718, #31727, #31732, #31736, #31763, #31880

[vbraun]

Changed branch from u/mkoeppe/manifoldsubset__union__intersection__declare__union_intersection__with_arbitrary_number_of_arguments to 582b58d