-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManifoldSubset: union, intersection, declare_{union,intersection} with arbitrary number of arguments #31764
Comments
Commit: |
Last 10 new commits:
|
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Doctests are missing for the methods |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
What about the Pyflakes error? (local variable 'old' is assigned to but never used) |
comment:10
Ready for review. The error indicated by the patchbot is unrelated to this ticket |
comment:11
Well, pyflakes is still not happy, despite comment:9 commit. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
Indeed... thanks for your patience |
comment:14
Sorry for the delay. LGTM. Thanks for this improvement! |
Reviewer: Eric Gourgoulhon |
comment:15
Thank you! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:19
Trivial merge with updated tickets, includes latest beta. |
In this ticket, we extend
union
anddeclare_union
as follows:disjoint
declare_union
is the same asdeclare_empty()
)declare_union
is the same asdeclare_equal(other)
)Likewise, we extend
declare_intersection
andintersection
.We also introduce
declare_disjoint(other)
- same asself.intersection(other).declare_empty()
Depends on #31680
Depends on #31718
Depends on #31727
Depends on #31732
Depends on #31736
Depends on #31763
Depends on #31880
CC: @egourgoulhon @mjungmath
Component: manifolds
Author: Matthias Koeppe
Branch/Commit:
582b58d
Reviewer: Eric Gourgoulhon
Issue created by migration from https://trac.sagemath.org/ticket/31764
The text was updated successfully, but these errors were encountered: