Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken p-adic getslice #3184

Closed
sagetrac-dmharvey mannequin opened this issue May 13, 2008 · 5 comments
Closed

broken p-adic getslice #3184

sagetrac-dmharvey mannequin opened this issue May 13, 2008 · 5 comments

Comments

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented May 13, 2008

(This ticket was split off from #2943)

This is okay:

sage: K = Qp(13,7)
sage: R.<t> = K[]       
sage: a = 13^7*t^3 + K(169,4)*t - 13^4
sage: a[1:2]
(13^2 + O(13^4))*t

This dies:

sage: t[0:1]
[boom]

The original context for this bug was along the lines of (see #2943 for more examples):

sage: K = Qp(p,10)
sage: C.<t> = LaurentSeriesRing(K)
sage: D.<s> = PolynomialRing(C)
sage: z = (1 + O(t)) + t*s^2
sage: z * z
[boom]

CC: @craigcitro

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/3184

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.0.2 milestone May 13, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Nov 23, 2008

comment:2

Craig has become a getslice expert, so let's CC him :)

Cheers,

Michael

@roed314
Copy link
Contributor

roed314 commented Jan 24, 2009

comment:3

Attachment: 3184.patch.gz

@jasongrout
Copy link
Member

comment:4

First comment: getslice is deprecated; it should be __getitem__ now.

Second, there is a standard block of code for slicing...using that will make sure that things are consistent for people that understand python slices.

@sagetrac-dmharvey
Copy link
Mannequin Author

sagetrac-dmharvey mannequin commented Mar 19, 2009

comment:5

Looks good to me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 20, 2009

comment:6

Merged in Sage 3.4.1.alpha0.

Cheeers,

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants