Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate some is_*** functions #32347

Closed
fchapoton opened this issue Aug 7, 2021 · 11 comments
Closed

deprecate some is_*** functions #32347

fchapoton opened this issue Aug 7, 2021 · 11 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@fchapoton
Copy link
Contributor

namely

is_field
is_commutative
is_integrally_closed

CC: @tscrim @slel

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 32f9927

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32347
@fchapoton fchapoton added this to the sage-9.4 milestone Aug 7, 2021
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32347

@fchapoton
Copy link
Contributor Author

New commits:

1197b41deprecate 3 is_something functions

@fchapoton
Copy link
Contributor Author

Commit: 1197b41

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

58f8ee7fix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2021

Changed commit from 1197b41 to 58f8ee7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

32f9927fix another doctest about is_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 8, 2021

Changed commit from 58f8ee7 to 32f9927

@fchapoton
Copy link
Contributor Author

comment:4

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Aug 8, 2021

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 8, 2021

Reviewer: Travis Scrimshaw

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@vbraun
Copy link
Member

vbraun commented Sep 5, 2021

Changed branch from u/chapoton/32347 to 32f9927

@vbraun vbraun closed this as completed in 18523b0 Sep 5, 2021
@mkoeppe mkoeppe mentioned this issue Jan 23, 2023
Open
@fchapoton fchapoton mentioned this issue Feb 14, 2024
Merged
2 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 18, 2024
sagemathgh-37342: remove some old deprecations in functional.py
60d0fbc 
    
remove functions deprecated in late 2021

in sagemath#32347

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37342
Reported by: Frédéric Chapoton
Reviewer(s): grhkm21
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 19, 2024
sagemathgh-37342: remove some old deprecations in functional.py
67c6dfc 
    
remove functions deprecated in late 2021

in sagemath#32347

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37342
Reported by: Frédéric Chapoton
Reviewer(s): grhkm21
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 22, 2024
sagemathgh-37342: remove some old deprecations in functional.py
805c152 
    
remove functions deprecated in late 2021

in sagemath#32347

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37342
Reported by: Frédéric Chapoton
Reviewer(s): grhkm21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe