Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/setup.py: Do not need Cython for sdist or egg_info #32673

Closed
tobiasdiez opened this issue Oct 12, 2021 · 5 comments
Closed

src/setup.py: Do not need Cython for sdist or egg_info #32673

tobiasdiez opened this issue Oct 12, 2021 · 5 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@tobiasdiez
Copy link
Contributor

In case src/setup.py is invoked with sdist or egg_info as argument, we do not need to generate code files or cythonize. This also removes the early dependency on Cython. Needed and extracted from #30371.

CC: @mkoeppe @kiwifb @jhpalmieri @isuruf

Component: build

Author: Tobias Diez

Branch/Commit: 17acb7b

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32673
@tobiasdiez tobiasdiez added this to the sage-9.5 milestone Oct 12, 2021
@tobiasdiez
Copy link
Contributor Author

Author: Tobias Diez

@mkoeppe mkoeppe changed the title Do not need Cython for sdist or egg_info src/setup.py: Do not need Cython for sdist or egg_info Oct 12, 2021
@mkoeppe
Copy link
Member

mkoeppe commented Oct 12, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Oct 12, 2021

comment:4

I've applied a similar change to #29865

@tobiasdiez
Copy link
Contributor Author

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 19, 2021

Changed branch from public/build/setup_dist to 17acb7b

@vbraun vbraun closed this as completed Oct 19, 2021
@mkoeppe mkoeppe mentioned this issue Oct 19, 2021
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32673
b1a47b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @mkoeppe