New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly fix slow down by #30022 #32775
Comments
Commit: |
comment:2
The test failures are not from this ticket:
|
Reviewer: Matthias Koeppe |
comment:3
Thanks for working on this! LGTM. |
comment:4
Thank you. |
comment:5
Not sure about |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:8
That seems better. Another option would have been to use from sage.libs.pari.convert_sage import (
set_integer_from_gen as set_integer_from_pari_gen) if that name mattered. |
Changed reviewer from Matthias Koeppe to Matthias Koeppe, Samuel Lelièvre |
comment:9
It was just a typo and made this whole construction pointless there. This is the reason, I modified the benchmarks as well. |
Changed branch from u/gh-kliem/fix_regression_of_30022 to |
We avoid multiple imports caused by #30022:
Before (and with #30022):
Reverting #30022:
With this ticket:
CC: @tscrim
Component: refactoring
Author: Jonathan Kliem
Branch/Commit:
4d7ac2f
Reviewer: Matthias Koeppe, Samuel Lelièvre
Issue created by migration from https://trac.sagemath.org/ticket/32775
The text was updated successfully, but these errors were encountered: