New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option "./configure --enable-wheels" #32874
Comments
This comment has been minimized.
This comment has been minimized.
New commits:
|
Author: Matthias Koeppe |
Commit: |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
./configure --disable-editable
is in use
comment:10
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:74
Replying to Kwankyu Lee:
No, not necessary any more; it probably was necessary with prehistoric versions of setuptools. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:76
Replying to Kwankyu Lee:
I've added a comment (and fixed a mistake that I had made along the way). |
comment:77
Thanks. It works well and looks good to me. |
comment:78
Thank you! |
Changed branch from u/mkoeppe/remove_use_of__setup_py_install__for_sagelib to |
Changed commit from |
comment:80
This makes tests depend on
|
comment:81
I've opened #34674 for this |
comment:82
A question to educate myself: In what environment, |
comment:83
In distribution packaging (Antonio does the packaging for Arch Linux), |
comment:84
Okay. Thanks. |
When
./configure --disable-editable
is in use (the default before #32406), the Sage library is installed using its custom incremental implementation ofsetup.py install
-- which installs its files insite-packages
and then removes the files that it does not know about (the "cleaner").Problem 1: The cleaner is incompatible with namespace packages and trying to fix it would lead to complicated and awkward code (#32927). (Besides,
setup.py install
is deprecated since https://setuptools.pypa.io/en/latest/history.html#v58-3-0)Problem 2: Because of the direct installation, we do not have wheels for sagemath-standard available (even if make wheels is used explicitly). Such wheels can be useful for making separate venvs.
In this ticket:
./configure --enable-wheels
(which can be used both with./configure --enable-editable
and./configure --disable-editable
).A trivial
./sage -b
is much slower with./configure --disable-editable --enable-wheels
compared to./configure --disable-editable
(from 28s as per timings in #32406 comment:21 to 70s).This ticket brings a number of speed improvements to mitigate this.
CC: @jhpalmieri
Component: build
Author: Matthias Koeppe
Branch:
25898ba
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/32874
The text was updated successfully, but these errors were encountered: