Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more W605 in rings #34645

Closed
fchapoton opened this issue Oct 10, 2022 · 8 comments
Closed

fix more W605 in rings #34645

fchapoton opened this issue Oct 10, 2022 · 8 comments

Comments

@fchapoton
Copy link
Contributor

after #34639

CC: @tscrim @slel @kwankyu @kliem

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 47a089d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34645

@fchapoton fchapoton added this to the sage-9.8 milestone Oct 10, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34645

@fchapoton
Copy link
Contributor Author

Commit: 47a089d

@fchapoton
Copy link
Contributor Author

New commits:

47a089dfix more W605 in rings/

@fchapoton
Copy link
Contributor Author

comment:2

bot and lights are morally green, so please review (should be easy)

@tscrim
Copy link
Collaborator

tscrim commented Oct 11, 2022

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 11, 2022

comment:4

Merge failure on top of:

c2baae7e947 Trac #34640: fix some pep8 in words/

4c44e082e69 Trac #34632: wrappers for acb_poly_[rl]gamma_series

bbd3c50d9c4 Trac #34629: Use the kbd role in the doc

561a8b88870 Trac #34625: Refresh the file free_quadratic_module

6eb9a59c7bc Trac #34622: partial cleanup in partition.py

b75e452282b Trac #34620: pep cleanup for the file weyl_group.py

d22e4b2de0f Trac #34619: fix some details in doc of charpoly_frobenius

1068d8fd597 Trac #34613: fix some typos

be07ee91bc3 Trac #34606: fix doc with respect to a change in behavior for tikz method of polyhedron (since 9.7 -> since 9.8)

2d712830271 Trac #34602: add some missing EXAMPLES

953c8949c60 Trac #34599: add helper function to compute all monomials of a given degree

f6c53f3520c Trac #34594: Fix error in sage.misc.latex.view doctest

15696c2bd7a Trac #34585: pep8 cleanup in algebras/letterplace pyx files

015bd808c45 Trac #34463: make PolynomialQuotientRing_generic inherit from QuotientRing_generic

098f47f3898 Trac #34394: pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 6)

aa4dc01bf54 Trac #34123: Fast initialization for edge connectivity

66a62fa Trac #34647: some details in permutation groups

1a1d67d Trac #34644: minor details in schemes

3384309 Trac #34639: fix some W605 in pyx files in rings

c448d77 Trac #34618: use libgap in dual abelian group elements

33a0f7a Trac #34617: fix and activate pycodestyle W391

7563675 Trac #34615: Update to sphinx 5.2

685a07c Trac #34614: add missing EllipticCurveHom methods to Îlu isogenies

a7dac85 Trac #34612: 1 internet doctest failing in graphs/isgci.py

d9c4091 Trac #34579: Faster iterator for planar set partitions

321f970 Trac #34552: more testsuites for lazy series rings

87626b0 Trac #34470: categories of lazy series

77c6eed Trac #34410: make new composite elliptic-curve isogenies the default

2356379 Trac #33969: Implement missing KnotInfo wrappers for polynomial invariants

a9abd3b Trac #32874: New option "./configure --enable-wheels"

84ecc3f Trac #32686: points_of_bounded_height for projective space is incorrect

364b605 Trac #29413: Meta-ticket: Upgrade cddlib, fix cddlib header search for packages latte_int, gfan, topcom

be3b5ab Trac #34609: 5 internet doctests failing in oeis

f1d4c32 Trac #34607: 2 doctests failures with external software octave

792d877 Trac #34603: Fix singular spkg-configure

12539de Trac #34268: Reduce R to a dummy package, upgrade rpy2 to 3.4.5

ac6888e Trac #33680: moving _repr_fixups list from doctest/parsing.py header to method do_fixup

b670d03 Trac #33597: Wrong computation of Hilbert polynomials

6b198bd Trac #32367: Replace Lazy Power Series in species directory

00ebfa9 Trac #32354: Fix integral(1/max_symbolic(x, 1)^2, x, 0, oo, algorithm='giac')

ad120da Trac #31588: Update Normaliz to 3.9.x, pynormaliz to 2.17, e-antic to 1.x, add optional package antic

fd47b99 Trac #14222: Coercion/conversion from Cone and other objects to Polyhedron

de29679 Trac #34623: Fix broken gitpod

e91fd4a Trac #34604: latte_int: Fix up patch

1758b63 Trac #34496: disallow PARI 2.15 from the system, until giac is fixed

54cd6fe Updated SageMath version to 9.8.beta1

reviewer '' does not look right

@fchapoton
Copy link
Contributor Author

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 17, 2022

Changed branch from u/chapoton/34645 to 47a089d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants