Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'MAKE="make V=0" make' and 'V=0 ./sage -b' are broken #33587

Closed
mkoeppe opened this issue Mar 29, 2022 · 14 comments
Closed

'MAKE="make V=0" make' and 'V=0 ./sage -b' are broken #33587

mkoeppe opened this issue Mar 29, 2022 · 14 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 29, 2022

Parts of our documentation (README.md, src/doc/en/faq/faq-usage.rst) recommend to use export MAKE="make -j4 -l5.5" or similar.

Other parts of the documentation recommend to add V=0 to a make command line.

If one combines both, putting V=0 inside the environment variable MAKE, one gets mysterious errors such as /bin/sh: @cd: command not found.

The same error also occurs when using export V=0 (as recommended in README.md) and then running ./sage -b.

CC: @yuan-zhou @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch/Commit: f1a7f20

Reviewer: John Palmieri, Guillermo Moreno-Socías

Issue created by migration from https://trac.sagemath.org/ticket/33587

@mkoeppe mkoeppe added this to the sage-9.6 milestone Mar 29, 2022
@mkoeppe mkoeppe changed the title MAKE="make -j4 -l5.5 -s V=0" make is broken MAKE="make V=0" make is broken Mar 29, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@GMS103
Copy link
Member

GMS103 commented Apr 25, 2022

comment:5

Slightly differently, after

export MAKE="make -j16"
export V=0

The command ./sage -br fails with the same error:

/bin/sh: @cd: command not found

Unsetting V eliminates the problem.

This is on SageMath 9.6.rc1.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.6 Apr 26, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2022

Commit: f1a7f20

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2022

New commits:

f1a7f20build/make/Makefile.in: Remove wrong uses of AM_V_at

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2022

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title MAKE="make V=0" make is broken 'MAKE="make V=0" make' and 'V=0 ./sage -b' are broken Apr 26, 2022
@jhpalmieri
Copy link
Member

comment:9

The fix works for me. I would like @GMS103 to test it, too.

@GMS103
Copy link
Member

GMS103 commented Apr 26, 2022

comment:10

Test just finished, positive review too.
Thanks.

@jhpalmieri
Copy link
Member

comment:11

Great! Feel free to add your name to the list of reviewers (click "Modify ticket" to edit that field).

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@GMS103
Copy link
Member

GMS103 commented Apr 26, 2022

Changed reviewer from John Palmieri to John Palmieri, Guillermo Moreno-Socías

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2022

comment:13

Thanks both!

@vbraun
Copy link
Member

vbraun commented Apr 28, 2022

Changed branch from u/mkoeppe/make__make_v_0__make_is_broken to f1a7f20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants