Skip to content

Commit

Permalink
Trac #33587: 'MAKE="make V=0" make' and 'V=0 ./sage -b' are broken
Browse files Browse the repository at this point in the history
Parts of our documentation (`README.md`, `src/doc/en/faq/faq-usage.rst`)
recommend to use `export MAKE="make -j4 -l5.5"` or similar.

Other parts of the documentation recommend to add `V=0` to a `make`
command line.

If one combines both, putting `V=0` inside the environment variable
`MAKE`, one gets mysterious errors such as `/bin/sh: @cd: command not
found`.

The same error also occurs when using `export V=0` (as recommended in
README.md) and then running `./sage -b`.

URL: https://trac.sagemath.org/33587
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): John Palmieri, Guillermo Moreno-Socías
  • Loading branch information
Release Manager committed Apr 26, 2022
2 parents 316f3f9 + f1a7f20 commit bc44ac8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/make/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ $(1)-$(4)-no-deps:
echo "$$($(4)_DISABLED_MESSAGE)" 2>&1; \
exit 1; \
else \
$(AM_V_at)sage-logger -p 'SAGE_CHECK=$$(SAGE_CHECK_$(1)) PATH=$$($(4))/bin:$$$$PATH $$(SAGE_SPKG) $$(SAGE_SPKG_OPTIONS) \
sage-logger -p 'SAGE_CHECK=$$(SAGE_CHECK_$(1)) PATH=$$($(4))/bin:$$$$PATH $$(SAGE_SPKG) $$(SAGE_SPKG_OPTIONS) \
$(if $(filter $(1),$(TOOLCHAIN_DEPS)),--keep-existing) \
$(1)-$(2) $$($(4))' '$$(SAGE_LOGS)/$(1)-$(2).log'; \
fi
Expand Down Expand Up @@ -615,7 +615,7 @@ $(1)-$(4)-no-deps:
echo "$$($(4)_DISABLED_MESSAGE)" 2>&1; \
exit 1; \
elif [ -x '$$(SAGE_ROOT)/build/pkgs/$(1)/spkg-install' ]; then \
$(AM_V_at)cd '$$(SAGE_ROOT)/build/pkgs/$(1)' && \
cd '$$(SAGE_ROOT)/build/pkgs/$(1)' && \
. '$$(SAGE_ROOT)/src/bin/sage-src-env-config' && \
. '$$(SAGE_ROOT)/src/bin/sage-env-config' && \
. '$$(SAGE_ROOT)/src/bin/sage-env' && \
Expand Down

0 comments on commit bc44ac8

Please sign in to comment.