Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make elliptic-curve isogenies compute Montgomery codomains #33708

Closed
yyyyx4 opened this issue Apr 14, 2022 · 10 comments
Closed

make elliptic-curve isogenies compute Montgomery codomains #33708

yyyyx4 opened this issue Apr 14, 2022 · 10 comments

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Apr 14, 2022

Following up on #33707, we can support passing model="montgomery" to the various isogeny functions in Sage.

Diff without the dependencies: sagemath/sagetrac-mirror@2833869...ec0aaf3

Depends on #33619
Depends on #33707

CC: @defeo @JohnCremona @categorie

Component: elliptic curves

Author: Lorenz Panny

Branch/Commit: ec0aaf3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33708

@yyyyx4 yyyyx4 added this to the sage-9.6 milestone Apr 14, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 24, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

628110eMerge tag '9.6.rc1' into public/montgomerize_isogeny_codomains
0242e3cremove unused import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 24, 2022

Changed commit from 4c145ed to 0242e3c

@yyyyx4 yyyyx4 modified the milestones: sage-9.6, sage-9.7 Apr 26, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2022

Changed commit from 0242e3c to 295b299

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

240cf80Merge branch 'develop' into t/33707/public/montgomerize_elliptic_curves-test
c093464Some edits mostly improving readibility of code
ff391f9One more edit
af5081aMerge tag '9.6.rc3' into public/montgomerize_elliptic_curves
4e380e2some more style tweaks
295b299Merge branch 'public/montgomerize_elliptic_curves' into public/montgomerize_isogeny_codomains

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2022

Changed commit from 295b299 to ec0aaf3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2022

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

206f62aspaces after commas
68cfda6small tweaks in docstring
cdab998demonstrate vanishing on full 2-torsion in example
37346c8remove some unnecessary polynomial-to-list conversions
454f3edE2 -> codomain in method names
f131ae3code style tweaks
de6552ehide internal helper function
2833869some doc tweaks
6f0ffeeMerge branch 'public/clean_up_ell_curve_isogeny_file' into public/montgomerize_isogeny_codomains
ec0aaf3doc tweak

@yyyyx4

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2022

comment:7

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jul 9, 2022

Changed branch from public/montgomerize_isogeny_codomains to ec0aaf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants