Update gcc/gfortran to 12.x + Apple Silicon support, update openblas to 0.3.21, gsl to 2.7.1 #33816

`1dfeb14`	`build/pkgs/gcc: Update to 12.2.0`
`9ae559b`	`build/pkgs/gcc/patches/gcc-12.2.0-arm.patch: Import from https://raw.githubusercontent.com/Homebrew/formula-patches/1d184289/gcc/gcc-12.2.0-arm.diff`

mkoeppe · 2022-09-20T20:15:08Z

Author: Matthias Koeppe

jhpalmieri · 2022-09-20T20:36:41Z

comment:7

I don't know if this is ready yet but I tried it anyway on my new M2 laptop. It failed; the end of the log file reads

0  0x1010cc1a0  __assert_rtn + 140
1  0x100f53a8c  mach_o::relocatable::Parser<arm64>::parse(mach_o::relocatable::ParserOptions const&) + 4536
2  0x100f25d38  mach_o::relocatable::Parser<arm64>::parse(unsigned char const*, unsigned long long, char const*, long, ld::File::Ordinal, mach_o::relocatable::ParserOptions const&) + 148
3  0x100f8e4ac  ld::tool::InputFiles::makeFile(Options::FileInfo const&, bool) + 1468
4  0x100f91360  ___ZN2ld4tool10InputFilesC2ER7Options_block_invoke + 56
5  0x188a041f4  _dispatch_client_callout2 + 20
6  0x188a17954  _dispatch_apply_invoke + 224
7  0x188a041b4  _dispatch_client_callout + 20
8  0x188a15a04  _dispatch_root_queue_drain + 680
9  0x188a16104  _dispatch_worker_thread2 + 164
10  0x188bc4324  _pthread_wqthread + 228
A linker snapshot was created at:
	/tmp/libstdc++.6.dylib-2022-09-20-133305.ld-snapshot
ld: Assertion failed: (_file->_atomsArrayCount == computedAtomCount && "more atoms allocated than expected"), function parse, file macho_relocatable_file.cpp, line 2061.

I can post the full log file if you want.

mkoeppe · 2022-09-20T20:49:18Z

comment:8

Thanks for testing. Also on Intel I ran into a build error. This will need more work.

jhpalmieri · 2022-09-20T20:56:02Z

comment:9

I'm happy to test. It's just a MacBook Air, but it builds Sage faster than my iMac Pro, and I like giving it tasks.

sagetrac-git · 2022-09-21T00:48:54Z

Branch pushed to git repo; I updated commit sha1. New commits:

`49c407b`	`build/pkgs/gcc/spkg-build.in: Remove workarounds for ancient OS X`

sagetrac-git · 2022-09-21T00:48:54Z

Changed commit from 9ae559b to 49c407b

sagetrac-git · 2022-09-21T01:58:29Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ba6de83`	`build/pkgs/gcc/build-gcc: Unset AS, LD`

sagetrac-git · 2022-09-21T01:58:29Z

Changed commit from 49c407b to ba6de83

mkoeppe · 2022-09-21T02:00:42Z

comment:12

On Intel, this still fails tox -e local-macos-nohomebrew -- gfortran, but it passes with the full bootstrapped build tox -e local-macos-nohomebrew -- gcc.

The failure when trying to build gfortran using Apple's gcc (clang) is introduced by the patch - passing the argument -nodefaultrpaths to the compiler.

sagetrac-git · 2022-09-21T02:29:00Z

Changed commit from ba6de83 to 5d9563b

sagetrac-git · 2022-09-21T02:29:00Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5d9563b`	`build/pkgs/gfortran/spkg-build.in: Work around build failure with Apple gcc (clang)`

mkoeppe · 2022-09-21T02:29:25Z

comment:14

This builds for me now on Intel. Haven't tested anything else yet

jhpalmieri · 2022-09-21T02:44:53Z

comment:15

Still fails for me on m2.

mkoeppe · 2022-09-21T02:45:30Z

comment:16

full log please

jhpalmieri · 2022-09-21T02:46:20Z

comment:17

Hold on, I tried make gcc. I'm going to try make gfortran and see how that goes.

jhpalmieri · 2022-09-21T02:53:18Z

comment:18

gfortran built successfully.

mkoeppe · 2022-09-21T02:55:14Z

comment:19

Great! I think we can ignore the failure to build gcc. We haven't been testing those in quite a while

mkoeppe · 2022-09-22T22:10:22Z

comment:59

There are some failures, I'll have to investigate what's going on there.

mkoeppe · 2022-09-23T00:21:08Z

comment:60

Looks like the failures are only due to a flaw in my new 2-stage workflow, related to the use of -arch=native. For example, looking into the config.log of the failing fflas_ffpack package on fedora-35-minimal https://github.com/mkoeppe/sage/actions/runs/3108109396/jobs/5036948018, one sees:

configure:18251: checking for use of MKL
configure:18268: result: no 
configure:18288: checking for BLAS
configure:18304: g++ -std=gnu++11 -o conftest -g -O2   -I. -I.. -I. -I./fflas-ffpack -fabi-version=6   -Wl,-rpath-link,/sage/local/lib -L/sage/local/lib -Wl,-rpath,/sage/local/lib -Wl,-rpath-link,/sage/local/lib -L/sage/local/lib -Wl,-rpath,/sage/local/lib  conftest.cpp  -lopenblas  >&5
configure:18304: $? = 0
configure:18304: ./conftest
./configure: line 1735: 100961 Illegal instruction     (core dumped) ./conftest$ac_exeext

mkoeppe · 2022-09-23T00:24:47Z

comment:61

I've opened #34572 to improve this.

jhpalmieri · 2022-09-23T02:13:41Z

comment:62

Do we need to test on OS X pre-Monterey? Otherwise, I'm ready to give this a positive review, at least from the OS X point of view.

mkoeppe · 2022-09-23T05:07:05Z

comment:63

A test on Catalina (10.15) ran at https://github.com/mkoeppe/sage/actions/runs/3094982845/jobs/5008934048, looks OK

mkoeppe · 2022-09-23T05:09:47Z

comment:64

I've manually tested tox -e docker-fedora-35-minimal (also ran make ptest), also fine.

I've also tested EXTRA_CONFIGURE_ARGS=--without-system-gfortran tox -e docker-ubuntu-trusty-toolchain-gcc_9-minimal, a bit of an usual configuration, which has a failure in src/sage/misc/inline_fortran.py, but I don't think this is important enough to investigate more

mkoeppe · 2022-09-23T05:10:36Z

comment:65

So I think this is ready to go

jhpalmieri · 2022-09-23T05:35:37Z

comment:66

Okay, let's merge it early in this release cycle, not that too many people are building our gfortran anyway...

jhpalmieri · 2022-09-23T05:35:37Z

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/3094982876, https://github.com/mkoeppe/sage/actions/runs/3108109396/jobs/5036946542 to John Palmieri

mkoeppe · 2022-09-23T05:51:31Z

comment:67

Thanks!

vbraun · 2022-09-26T22:36:31Z

comment:68

Full run: http://build.sagemath.org/#/builders/15/builds/5

Flint testsuite dies on the kucalc buildbot (Ubuntu 16.04.5 LTS)

gcc -g -O2 -I/var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage/build/flint-2.8.4/src -I/var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage/build/flint-2.8.4/src/build -I/var/lib/buildbot/slave/sage_git/build/local/include -I/var/lib/buildbot/slave/sage_git/build/local/include -I/var/lib/buildbot/slave/sage_git/build/local/include test_helpers.o test/t-sdiv_qrnnd.c -o build/test/t-sdiv_qrnnd -L/var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage/build/flint-2.8.4/src -L/var/lib/buildbot/slave/sage_git/build/local/lib -L/var/lib/buildbot/slave/sage_git/build/local/lib -L/var/lib/buildbot/slave/sage_git/build/local/lib -lflint -lmpfr -lgmp -lm -lntl -lpthread  -Wl,-rpath-link,/var/lib/buildbot/slave/sage_git/build/local/lib -L/var/lib/buildbot/slave/sage_git/build/local/lib -Wl,-rpath,/var/lib/buildbot/slave/sage_git/build/local/lib -Wl,-rpath-link,/var/lib/buildbot/slave/sage_git/build/local/lib -L/var/lib/buildbot/slave/sage_git/build/local/lib -Wl,-rpath,/var/lib/buildbot/slave/sage_git/build/local/lib  -Wl,-rpath,/var/lib/buildbot/slave/sage_git/build/local/lib -Wl,-rpath,/var/lib/buildbot/slave/sage_git/build/local/lib -Wl,-rpath,/var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage/build/flint-2.8.4/src
(WANTDEPS=1; export WANTDEPS; BUILD_DIR=build; export BUILD_DIR; make -f Makefile.subdirs -C . check || exit $?;)
sub_dddmmmsss....invert_limb....udiv_qrnnd....add_ssssaaaaaaaa....byte_swap....umul_ppmm....add_ssaaaa....add_sssaaaaaa....udiv_qrnnd_preinv....PASS
smul_ppmm....count_leading_zeros....count_trailing_zeros....PASS
sub_ddmmss....PASS
sdiv_qrnnd....PASS
PASS
PASS
Makefile.subdirs:107: recipe for target 'build/test/t-sdiv_qrnnd_RUN' failed
make[6]: *** [build/test/t-sdiv_qrnnd_RUN] Floating point exception (core dumped)
PASS
PASS
PASS
PASS
PASS
PASS
PASS
make[6]: Target 'check' not remade because of errors.
Makefile:219: recipe for target 'check' failed
make[5]: *** [check] Error 2

jhpalmieri · 2022-09-26T22:48:24Z

comment:69

Our web page https://trac.sagemath.org/wiki/ReleaseTours/sage-9.8#Configurationchanges says "Users of older Linux distributions (in particular, ubuntu-xenial or older, debian-stretch or older, linuxmint-18 or older) should upgrade their systems before attempting to install Sage from source." So does a test failure on Ubuntu 16.04 matter?

mkoeppe · 2022-09-27T00:33:04Z

comment:70

Yes, I think this buildbot should be updated to a supported configuration, for example using https://askubuntu.com/questions/1140183/install-gcc-9-on-ubuntu-18-04/1149383#1149383

jhpalmieri · 2022-10-12T18:31:01Z

comment:71

So do we just set this back to positive, or does someone have to do something with the buildbot first?

vbraun · 2022-10-17T22:44:06Z

Changed branch from u/mkoeppe/update_gcc_gfortran_to_12_x___apple_silicon_support to e89ba55

### 📝 Checklist     Since Sage 9.8, it is no longer required to use homebrew when building on M1/M2 because of: - sagemath#33816 Here we correct the README. - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36828 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri

mkoeppe added this to the sage-9.7 milestone May 6, 2022

mkoeppe added c: packages: standard labels May 6, 2022

mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Update gcc/gfortran to 12.1~~ Update gcc/gfortran to 12.x + Apple Silicon support Sep 20, 2022

jhpalmieri added s: positive review and removed s: needs review labels Sep 23, 2022

vbraun added s: needs work and removed s: positive review labels Sep 26, 2022

mkoeppe added s: positive review and removed s: needs work labels Oct 13, 2022

vbraun removed the s: positive review label Oct 17, 2022

vbraun closed this as completed in 25d8bdc Oct 17, 2022

This was referenced Jan 1, 2023

Meta-ticket: Port to Apple silicon #30592

Closed

CI target ticket for setuptools #33288

Closed

Installation guide: Improve section on prerequisites/recommendations #34528

Closed

This was referenced Dec 6, 2023

README.md: Update section on macOS arm64 #36828

Merged

CI Linux: Replace use of pkill #36726

Merged

Update gcc/gfortran to 12.x + Apple Silicon support, update openblas to 0.3.21, gsl to 2.7.1 #33816

Update gcc/gfortran to 12.x + Apple Silicon support, update openblas to 0.3.21, gsl to 2.7.1 #33816

Comments

mkoeppe commented May 6, 2022

mkoeppe commented May 20, 2022

mkoeppe commented Jun 30, 2022

This comment has been minimized.

mkoeppe commented Sep 20, 2022

mkoeppe commented Sep 20, 2022

mkoeppe commented Sep 20, 2022

mkoeppe commented Sep 20, 2022

jhpalmieri commented Sep 20, 2022

mkoeppe commented Sep 20, 2022

jhpalmieri commented Sep 20, 2022

sagetrac-git mannequin commented Sep 21, 2022

sagetrac-git mannequin commented Sep 21, 2022

sagetrac-git mannequin commented Sep 21, 2022

sagetrac-git mannequin commented Sep 21, 2022

mkoeppe commented Sep 21, 2022

sagetrac-git mannequin commented Sep 21, 2022

sagetrac-git mannequin commented Sep 21, 2022

mkoeppe commented Sep 21, 2022

jhpalmieri commented Sep 21, 2022

mkoeppe commented Sep 21, 2022

jhpalmieri commented Sep 21, 2022

jhpalmieri commented Sep 21, 2022

mkoeppe commented Sep 21, 2022

mkoeppe commented Sep 22, 2022

mkoeppe commented Sep 23, 2022

mkoeppe commented Sep 23, 2022

jhpalmieri commented Sep 23, 2022

mkoeppe commented Sep 23, 2022

mkoeppe commented Sep 23, 2022

mkoeppe commented Sep 23, 2022

jhpalmieri commented Sep 23, 2022

jhpalmieri commented Sep 23, 2022

mkoeppe commented Sep 23, 2022

vbraun commented Sep 26, 2022

jhpalmieri commented Sep 26, 2022

mkoeppe commented Sep 27, 2022

jhpalmieri commented Oct 12, 2022

vbraun commented Oct 17, 2022