Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more W391 #34596

Closed
fchapoton opened this issue Sep 28, 2022 · 14 comments
Closed

fix more W391 #34596

fchapoton opened this issue Sep 28, 2022 · 14 comments

Comments

@fchapoton
Copy link
Contributor

and a few other things:

  • not using (object)

  • some more precise asserts

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 188910c

Reviewer: Martin Rubey

Issue created by migration from https://trac.sagemath.org/ticket/34596

@fchapoton fchapoton added this to the sage-9.8 milestone Sep 28, 2022
@fchapoton
Copy link
Contributor Author

Commit: 86648c2

@fchapoton
Copy link
Contributor Author

New commits:

86648c2some care for W391 (final empty lines) and a few other things

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34596

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 28, 2022

Changed commit from 86648c2 to bb97cf1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 28, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bb97cf1fix detail

@mantepse
Copy link
Contributor

comment:3

Please do not modify stream.py right now, this might hold up the long chain of tickets fixing really evil bugs, culminating in #34552.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 28, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

188910csome care for W391 (final empty lines) and a few other things

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 28, 2022

Changed commit from bb97cf1 to 188910c

@fchapoton
Copy link
Contributor Author

comment:5

ok, now not touching this file at all

@mantepse
Copy link
Contributor

comment:6

In dev_tools.py, it is unclear why you do not replace object in the following line

    for obj in itertools.chain.from_iterable(expand_comma_separated_names(object)
                                             for object in objects):

(although I admit it is unclear to me, why you replace object at all)

@fchapoton
Copy link
Contributor Author

comment:7

once done, we will be able to check that nobody uses the obsolete syntax class C(object): anymore.

@mantepse
Copy link
Contributor

Reviewer: Martin Rubey

@mantepse
Copy link
Contributor

comment:8

Thank you!

@vbraun
Copy link
Member

vbraun commented Sep 29, 2022

Changed branch from u/chapoton/34596 to 188910c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants