Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix W391 in modules, tests and rings #34601

Closed
fchapoton opened this issue Sep 28, 2022 · 5 comments
Closed

fix W391 in modules, tests and rings #34601

fchapoton opened this issue Sep 28, 2022 · 5 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

with #34596, we are almost there

one file in rings is left aside for the moment

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: d4eddec

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34601
@fchapoton fchapoton added this to the sage-9.8 milestone Sep 28, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34601

@fchapoton
Copy link
Contributor Author

New commits:

d4eddecfix W391 in tests, modules, rings

@fchapoton
Copy link
Contributor Author

Commit: d4eddec

@mkoeppe
Copy link
Member

mkoeppe commented Sep 28, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Sep 29, 2022

Changed branch from u/chapoton/34601 to d4eddec

@vbraun vbraun closed this as completed in d30d2ff Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe