Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singular spkg-configure #34603

Closed
mkoeppe opened this issue Sep 28, 2022 · 10 comments
Closed

Fix singular spkg-configure #34603

mkoeppe opened this issue Sep 28, 2022 · 10 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 28, 2022

Seen on archlinux-latest, https://github.com/FFY00/meson-python/actions/runs/3146686714/jobs/5115498470

Checking whether SageMath should install SPKG singular...
checking whether any of gmp ntl flint readline mpfr cddlib is installed as or will be installed as SPKG... no
checking for Singular... /usr/sbin/Singular
checking for SINGULAR... yes
checking that Singular's help is working... grep: warning: stray \ before white space
./configure: line 43759: test: too many arguments
no
configure: no suitable system package found for SPKG singular

CC: @dimpase @orlitzky

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 373bd38

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34603

@mkoeppe mkoeppe added this to the sage-9.8 milestone Sep 28, 2022
@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

comment:1

Does archlinux-latest use some sort of weird grep (3.8, the latest version from last month)? The error comes from

AS_IF([test x`printf "system(\"--browser\", \"builtin\"); \n help;" | Singular 2>&1 | grep "error\ occurred"` = x], [

i.e. grep does not understand "error\ occurred".

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

comment:2

I've built grep 3.8, and indeed, I get a warning:

$ /tmp/bin/grep "bla\ baz" t # this is grep 3.8
/tmp/bin/grep: warning: stray \ before white space
bla baz
$ cat t
bla foo
bla baz
$ grep "bla\ baz" t # this is grep 3.6
bla baz

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

comment:3

we can eiher just remove \ in the pattern, or send the warning to dev/null. Not sure what's the best, so I asked:

https://unix.stackexchange.com/questions/719384/the-correct-way-to-deal-with-spaces-in-a-pattern-for-grep

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

comment:4

It seems we can just remove that \. I'll make a branch

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

Commit: 373bd38

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

Branch: u/dimpase/configure/nobackslash

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

New commits:

373bd38remove harmful \

@dimpase
Copy link
Member

dimpase commented Oct 1, 2022

Author: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 1, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Oct 11, 2022

Changed branch from u/dimpase/configure/nobackslash to 373bd38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants