Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latte_int: Fix up patch #34604

Closed
mkoeppe opened this issue Sep 28, 2022 · 10 comments
Closed

latte_int: Fix up patch #34604

mkoeppe opened this issue Sep 28, 2022 · 10 comments
Labels
c: packages: optional p: critical / 2 t: bug
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 28, 2022

#33981 broke the latte_int package.

Related: latte-int/latte#31

CC: @kiwifb @jhpalmieri @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: c5202ea

Reviewer: François Bissey, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/34604
@mkoeppe mkoeppe added this to the sage-9.8 milestone Sep 28, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 28, 2022

Branch: u/mkoeppe/latte_int__fix_up_patch

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 28, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 28, 2022

Commit: c5202ea

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 28, 2022

New commits:

c5202eabuild/pkgs/latte_int/patches/6dbf7f07d5c9e1f3afe793f782d191d4465088ae.patch: Remove hunks for files not in the distribution

@mkoeppe

This comment has been minimized.

Sign in to view
@jhpalmieri
Copy link
Member

comment:3

On Apple M2 it builds and passes its test suite, and sage/interfaces/latte.py passes its tests with --optional=latte_int,sage, as does sage/geometry.

@kiwifb
Copy link
Member

kiwifb commented Sep 28, 2022

Reviewer: François Bissey, John Palmieri

@kiwifb
Copy link
Member

kiwifb commented Sep 28, 2022

comment:4

LGTM as the person who raised the github issue.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 29, 2022

comment:5

Thanks both!

@vbraun
Copy link
Member

vbraun commented Oct 11, 2022

Changed branch from u/mkoeppe/latte_int__fix_up_patch to c5202ea

@vbraun vbraun closed this as completed in e91fd4a Oct 11, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@kiwifb @vbraun @jhpalmieri @mkoeppe