Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some details in doc of charpoly_frobenius #34619

Closed
fchapoton opened this issue Sep 30, 2022 · 14 comments
Closed

fix some details in doc of charpoly_frobenius #34619

fchapoton opened this issue Sep 30, 2022 · 14 comments

Comments

@fchapoton
Copy link
Contributor

and also pep8 standard for the code in this file

Component: algebraic geometry

Author: Frédéric Chapoton

Branch/Commit: 0e88192

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34619

@fchapoton
Copy link
Contributor Author

New commits:

5b78749fix some details in doc of charpoly_frobenius

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34619

@fchapoton
Copy link
Contributor Author

Commit: 5b78749

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

402bec3fix a bunch of similar errors in the doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Changed commit from 5b78749 to 402bec3

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

comment:3

this one is not correct

-        If the `primitive_root` does not lie in an extension of `field`,
+        If the ``primitive_root`̀  does not lie in an extension of ``field``,

The . should be outside

+or just through ``finite_dynamical_systems.``

@fchapoton
Copy link
Contributor Author

comment:4

Merci pour les suggestions.

Je ne comprends pas ce qui n'est pas correct dans le premier point, et je ne suis pas d'accord avec le second point. On est en train de parler de complétion-par-tab, donc le point va avec le reste.

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

comment:5

C'est peut-être un problème d'affichage chez moi, mais je vois 2 ` l'un au dessus de l'autre:

``primitive_root`̀ -> ``primitive_root``

pour le 2e point, tu as raison, je n'avais pas fait attention au context.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2022

Changed commit from 402bec3 to 0e88192

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0e88192fix one detail

@fchapoton
Copy link
Contributor Author

comment:7

peut-être mieux maintenant ?

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

comment:8

oui.

LGTM

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/chapoton/34619 to 0e88192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants