Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some details in permutation groups #34647

Closed
fchapoton opened this issue Oct 10, 2022 · 7 comments
Closed

some details in permutation groups #34647

fchapoton opened this issue Oct 10, 2022 · 7 comments
Labels
c: group theory p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

mostly a few pep8 changes

CC: @tscrim @kwankyu @kliem @slel

Component: group theory

Author: Frédéric Chapoton

Branch/Commit: 16fd967

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34647
@fchapoton fchapoton added this to the sage-9.8 milestone Oct 10, 2022
@fchapoton
Copy link
Contributor Author

New commits:

16fd967some details in permutation groups

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34647

@fchapoton
Copy link
Contributor Author

Commit: 16fd967

@fchapoton
Copy link
Contributor Author

comment:2

green lights, so please review, should be an easy one

@tscrim
Copy link
Collaborator

tscrim commented Oct 11, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 11, 2022

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/chapoton/34647 to 16fd967

@vbraun vbraun closed this as completed in 66a62fa Oct 16, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: group theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton