Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional package soplex (dependency of scip) #34742

Closed
mkoeppe opened this issue Nov 11, 2022 · 18 comments
Closed

Optional package soplex (dependency of scip) #34742

mkoeppe opened this issue Nov 11, 2022 · 18 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 11, 2022

https://github.com/scipopt/soplex

CC: @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: dbff7a0

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34742

@mkoeppe mkoeppe added this to the sage-9.8 milestone Nov 11, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 11, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 11, 2022

New commits:

e3a0531build/pkgs/soplex: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 11, 2022

Commit: e3a0531

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

957e657build/pkgs/soplex: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2022

Changed commit from e3a0531 to 957e657

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2022

Changed commit from 957e657 to 19614bc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

19614bcbuild/pkgs/soplex: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 12, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 12, 2022

comment:6

On macOS, install_name is broken

$ otool -L /Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/local/lib/libsoplexshared.dylib                                                                          git:t/21003/pyscipopt
/Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/local/lib/libsoplexshared.dylib:
	libsoplexshared.6.0.dylib (compatibility version 6.0.0, current version 6.0.2)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/gmp/lib/libgmp.10.dylib (compatibility version 15.0.0, current version 15.1.0)
	/usr/local/opt/gmp/lib/libgmpxx.4.dylib (compatibility version 11.0.0, current version 11.1.0)
	/usr/local/opt/mpfr/lib/libmpfr.6.dylib (compatibility version 8.0.0, current version 8.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

dbff7a0build/pkgs/soplex: Fix install_name on macOS

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2022

Changed commit from 19614bc to dbff7a0

@dimpase
Copy link
Member

dimpase commented Dec 11, 2022

comment:9

lgtm

@dimpase
Copy link
Member

dimpase commented Dec 11, 2022

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/3448901075 to Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 11, 2022

comment:10

Thank you

@dcoudert
Copy link
Contributor

comment:11

The patchbot reports an error when trying to build the doc

[sagemath_doc_html-none] [spkg     ] /home/sagemath/sage/src/doc/en/reference/spkg/soplex.rst: WARNING: document isn't included in any toctree
[sagemath_doc_html-none] [spkg     ] The inventory files are in ../../local/share/doc/sage/inventory/en/reference/spkg.
[sagemath_doc_html-none] Error building the documentation.
[sagemath_doc_html-none] Traceback (most recent call last):
[sagemath_doc_html-none]   File "/home/sagemath/sage/local/var/lib/sage/venv-python3.10.8/lib/python3.10/runpy.py", line 196, in _run_module_as_main
[sagemath_doc_html-none]     return _run_code(code, main_globals, None,
[sagemath_doc_html-none]   File "/home/sagemath/sage/local/var/lib/sage/venv-python3.10.8/lib/python3.10/runpy.py", line 86, in _run_code
[sagemath_doc_html-none]     exec(code, run_globals)
[sagemath_doc_html-none]   File "/home/sagemath/sage/pkgs/sage-docbuild/sage_docbuild/__main__.py", line 498, in <module>
[sagemath_doc_html-none]     sys.exit(main())
[sagemath_doc_html-none]   File "/home/sagemath/sage/pkgs/sage-docbuild/sage_docbuild/__main__.py", line 495, in main
[sagemath_doc_html-none]     builder()
[sagemath_doc_html-none]   File "/home/sagemath/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 819, in _wrapper
[sagemath_doc_html-none]     getattr(DocBuilder, build_type)(self, *args, **kwds)
[sagemath_doc_html-none]   File "/home/sagemath/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 163, in f
[sagemath_doc_html-none]     runsphinx()
[sagemath_doc_html-none]   File "/home/sagemath/sage/pkgs/sage-docbuild/sage_docbuild/sphinxbuild.py", line 327, in runsphinx
[sagemath_doc_html-none]     sys.stderr.raise_errors()
[sagemath_doc_html-none]   File "/home/sagemath/sage/pkgs/sage-docbuild/sage_docbuild/sphinxbuild.py", line 263, in raise_errors
[sagemath_doc_html-none]     raise OSError(self._error)
[sagemath_doc_html-none] OSError: /home/sagemath/sage/src/doc/en/reference/spkg/soplex.rst: WARNING: document isn't included in any toctree
[sagemath_doc_html-none] 
[sagemath_doc_html-none]     Note: incremental documentation builds sometimes cause spurious
[sagemath_doc_html-none]     error messages. To be certain that these are real errors, run
[sagemath_doc_html-none]     "make doc-clean doc-uninstall" first and try again.
[sagemath_doc_html-none] make[4]: *** [Makefile:28: doc-inventory--reference-spkg] Error 1
[sagemath_doc_html-none] make[4]: *** Waiting for unfinished jobs....
[sagemath_doc_html-none] [algebras ] The inventory files are in ../../local/share/doc/sage/inventory/en/reference/algebras.
[sagemath_doc_html-none] Build finished. The built documents can be found in /home/sagemath/sage/local/share/doc/sage/inventory/en/reference/algebras
[sagemath_doc_html-none] [manifolds] The inventory files are in ../../local/share/doc/sage/inventory/en/reference/manifolds.
[sagemath_doc_html-none] Build finished. The built documents can be found in /home/sagemath/sage/local/share/doc/sage/inventory/en/reference/manifolds
[sagemath_doc_html-none] make[3]: *** [Makefile:45: doc-inventory-reference] Error 2
make[2]: *** [Makefile:3228: sagemath_doc_html-SAGE_DOCS-no-deps] Error 2
make[1]: *** [Makefile:3228: /home/sagemath/sage/local/var/lib/sage/installed/sagemath_doc_html-none] Error 2
make[1]: Leaving directory '/home/sagemath/sage/build/make'

@dimpase
Copy link
Member

dimpase commented Dec 17, 2022

comment:12

incremental rebuild of docs can't cope with a new document added, maybe?

@dcoudert
Copy link
Contributor

comment:13

Right, but the patchbot compiles from scratch, no ?

@vbraun
Copy link
Member

vbraun commented Jan 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants