Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages dsdp, scip_sdp #34749

Closed
mkoeppe opened this issue Nov 15, 2022 · 68 comments
Closed

Packages dsdp, scip_sdp #34749

mkoeppe opened this issue Nov 15, 2022 · 68 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 15, 2022

http://www.opt.tu-darmstadt.de/scipsdp/#about

https://github.com/scipopt/SCIP-SDP

used to be LGPL license, changed to Apache 2.0 in Dec 2022

For full functionality, needs an SDP solver, one of:

Depends on #31329
Depends on #34835

CC: @dimpase @vbraun

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 544d123

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34749

@mkoeppe mkoeppe added this to the sage-9.8 milestone Nov 15, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

Dependencies: #31329

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Package scipsdp Package scip_sdp Dec 6, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

Branch: u/mkoeppe/package_scip_sdp

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

Commit: 8a954ab

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

comment:5

First draft of the install script

[scip_sdp-4.1.0] -- Build shared libraries: ON
[scip_sdp-4.1.0] -- Found lapack library: /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/liblapack.tbd
[scip_sdp-4.1.0] -- Found blas library: /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/libblas.tbd

needs to be changed so it uses our openblas

[scip_sdp-4.1.0] -- Finding symmetry computation program "bliss"
[scip_sdp-4.1.0] -- Finding BLISS
[scip_sdp-4.1.0] -- Finding BLISS - found
...
[scip_sdp-4.1.0] /Users/mkoeppe/s/sage/sage-rebasing/local/var/tmp/sage/build/scip_sdp-4.1.0/src/src/symmetry/compute_symmetry_bliss.cpp:42:10: fatal error: 'bliss/defs.hh' file not found
[scip_sdp-4.1.0] #include <bliss/defs.hh>
[scip_sdp-4.1.0]          ^~~~~~~~~~~~~~~

needs to be find scip's vendored bliss (or we need to unvendor - #33010/#34747)


Last 10 new commits:

68fb9a7build/pkgs/scipoptsuite/dependencies: Add papilo
2dd029ebuild/pkgs/{scipoptsuite,soplex}: Use papilo
5efb7babuild/pkgs/soplex/dependencies: Add papilo
0fc60a0build/pkgs/scipoptsuite: Fix install_name on macOS
392455dbuild/pkgs/scip: Rename from scipoptsuite
45f957eRevert "build/pkgs/boost_cropped/distros/debian.txt: Add libboost-program-options-dev"
931e348Merge #34726
9b40272build/pkgs/scip/distros/conda.txt: New
6221180Merge #31329
8a954abbuild/pkgs/scip_sdp: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

comment:6

The failure with bliss was due to a broken local installation

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2022

Changed commit from 8a954ab to 8250adb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8250adbbuild/pkgs/scip_sdp/spkg-install.in: Better config

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

comment:9

Many linker errors on macOS:

[scip_sdp-4.1.0] [100%] Linking CXX shared library ../lib/libscipsdp.dylib
[scip_sdp-4.1.0] cd /Users/mkoeppe/s/sage/sage-rebasing/local/var/tmp/sage/build/scip_sdp-4.1.0/src/build/src && /usr/local/Cellar/cmake/3.24.2/bin/cmake -E cmake_link_script CMakeFiles/libscipsdp.dir/link.txt --verbose=1
[scip_sdp-4.1.0] /Library/Developer/CommandLineTools/usr/bin/g++  -std=gnu++11 -g -O2 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk -dynamiclib -Wl,-headerpad_max_install_names -L/Users/mkoeppe/s/sage/sage-rebasing/local/lib -Wl,-rpath,/Users/mkoeppe/s/sage/sage-rebasing/local/lib -L/Users/mkoeppe/s/sage/sage-rebasing/local/lib -Wl,-rpath,/Users/mkoeppe/s/sage/sage-rebasing/local/lib -compatibility_version 4.1.0 -current_version 4.1.0 -o ../lib/libscipsdp.4.1.0.dylib -install_name libscipsdp.4.1.dylib CMakeFiles/libscipsdp.dir/scipsdp/SdpVarmapper.c.o CMakeFiles/libscipsdp.dir/scipsdp/SdpVarfixer.c.o CMakeFiles/libscipsdp.dir/scipsdp/cons_sdp.c.o CMakeFiles/libscipsdp.dir/scipsdp/cons_savedsdpsettings.c.o CMakeFiles/libscipsdp.dir/scipsdp/cons_savesdpsol.c.o CMakeFiles/libscipsdp.dir/scipsdp/relax_sdp.c.o CMakeFiles/libscipsdp.dir/scipsdp/disp_sdpiterations.c.o CMakeFiles/libscipsdp.dir/scipsdp/disp_sdpavgiterations.c.o CMakeFiles/libscipsdp.dir/scipsdp/disp_sdpfastsettings.c.o CMakeFiles/libscipsdp.dir/scipsdp/disp_sdppenalty.c.o CMakeFiles/libscipsdp.dir/scipsdp/disp_sdpunsolved.c.o CMakeFiles/libscipsdp.dir/scipsdp/prop_sdpredcost.c.o CMakeFiles/libscipsdp.dir/scipsdp/branch_sdpmostfrac.c.o CMakeFiles/libscipsdp.dir/scipsdp/branch_sdpmostinf.c.o CMakeFiles/libscipsdp.dir/scipsdp/branch_sdpobjective.c.o CMakeFiles/libscipsdp.dir/scipsdp/branch_sdpinfobjective.c.o CMakeFiles/libscipsdp.dir/scipsdp/heur_sdpfracround.c.o CMakeFiles/libscipsdp.dir/scipsdp/heur_sdpinnerlp.c.o CMakeFiles/libscipsdp.dir/scipsdp/heur_sdpfracdiving.c.o CMakeFiles/libscipsdp.dir/scipsdp/heur_sdprand.c.o CMakeFiles/libscipsdp.dir/scipsdp/prop_sdpsymmetry.c.o CMakeFiles/libscipsdp.dir/scipsdp/prop_sdpobbt.c.o CMakeFiles/libscipsdp.dir/scipsdp/prop_companalcent.c.o CMakeFiles/libscipsdp.dir/scipsdp/reader_cbf.c.o CMakeFiles/libscipsdp.dir/scipsdp/reader_sdpa.c.o CMakeFiles/libscipsdp.dir/scipsdp/sdpsymmetry.c.o CMakeFiles/libscipsdp.dir/scipsdp/table_relaxsdp.c.o CMakeFiles/libscipsdp.dir/scipsdp/table_slater.c.o CMakeFiles/libscipsdp.dir/scipsdp/scipsdpdefplugins.c.o CMakeFiles/libscipsdp.dir/sdpi/sdpi.c.o CMakeFiles/libscipsdp.dir/sdpi/sdpsolchecker.c.o CMakeFiles/libscipsdp.dir/sdpi/solveonevarsdp.c.o CMakeFiles/libscipsdp.dir/sdpi/lapack_interface.c.o CMakeFiles/libscipsdp.dir/sdpi/sdpiclock.c.o CMakeFiles/libscipsdp.dir/scipsdpgithash.c.o CMakeFiles/libscipsdp.dir/sdpi/sdpisolver_none.c.o CMakeFiles/libscipsdp.dir/symmetry/compute_symmetry_bliss.cpp.o  /Users/mkoeppe/s/sage/sage-rebasing/local/lib/libbliss.a /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/liblapack.tbd /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/libblas.tbd -lm 
...
scip_sdp-4.1.0]   "_SCIPverbMessage", referenced from:
[scip_sdp-4.1.0]       _consLockSdp in cons_sdp.c.o
[scip_sdp-4.1.0]       _consExitSdp in cons_sdp.c.o
[scip_sdp-4.1.0]       _consPresolSdp in cons_sdp.c.o
[scip_sdp-4.1.0]       _relaxInitSolSdp in relax_sdp.c.o
[scip_sdp-4.1.0]       _relaxExitSolSdp in relax_sdp.c.o
[scip_sdp-4.1.0]       _SCIPparamChgdSolvesdps in relax_sdp.c.o
[scip_sdp-4.1.0]       _SCIPrelaxSdpComputeAnalyticCenters in relax_sdp.c.o
[scip_sdp-4.1.0]       ...
[scip_sdp-4.1.0]   "_SCIPwarningMessage", referenced from:
[scip_sdp-4.1.0]       _calcRelax in relax_sdp.c.o
[scip_sdp-4.1.0]       _determineSymmetry in prop_sdpsymmetry.c.o
[scip_sdp-4.1.0]       _readerReadSdpa in reader_sdpa.c.o
[scip_sdp-4.1.0] ld: symbol(s) not found for architecture x86_64
[scip_sdp-4.1.0] clang: error: linker command failed with exit code 1 (use -v to see invocation)
[scip_sdp-4.1.0] make[5]: *** [lib/libscipsdp.4.1.0.dylib] Error 1

Looks like it forgets to link the scip library

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2022

comment:10

Opened scipopt/SCIP-SDP#1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0a5647abuild/pkgs/scip_sdp/patches: Add macOS build patches

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2022

Changed commit from 8250adb to 0a5647a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Changed commit from 0a5647a to f90180c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f90180cbuild/pkgs/dsdp: New dummy package

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 9, 2022

comment:13

https://github.com/cvxopt/cvxopt-wheels/blob/master/library_builders.sh has an install script for dsdp

@dimpase
Copy link
Member

dimpase commented Dec 9, 2022

comment:14

DSDP should be a separate Sage package, I think.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 9, 2022

comment:15

Yes, but this ancient package has no proper build system. Various ad hoc installation scripts in downstream packages:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Changed commit from f90180c to f7e21a0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

98155a5build/pkgs/dsdp: Add installation script
4d02672build/pkgs/dsdp/distros/conda.txt: New
f7e21a0build/pkgs/scip_sdp: Use upstream patch https://github.com/scipopt/SCIP-SDP/commit/09e79cf75146ca34c637f919d1f4527a63743300, configure blas/lapack

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Changed commit from f7e21a0 to a90f917

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a90f917build/pkgs/dsdp/patches/debian-type-mismatch.patch: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

24dae35build/pkgs/dsdp/distros/repology.txt: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8ef2ea4build/pkgs/scip_sdp/patches/another_blas_change.patch: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2022

Changed commit from a10dd81 to 8ef2ea4

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 10, 2022

comment:39

scipopt/SCIP-SDP#5

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 10, 2022

comment:40

archlinux-latest-standard (https://github.com/mkoeppe/SCIP-SDP/actions/runs/3660649526/jobs/6190005686)

  [scip_sdp-git]   /usr/sbin/g++  -std=gnu++11 -g -O2 -Wl,-rpath-link,/sage/local/lib -L/sage/local/lib -Wl,-rpath,/sage/local/lib -Wl,-rpath-link,/sage/local/lib -L/sage/local/lib -Wl,-rpath,/sage/local/lib -rdynamic CMakeFiles/scipsdp.dir/scipsdp/main.c.o CMakeFiles/scipsdp.dir/scipsdp/SdpVarmapper.c.o CMakeFiles/scipsdp.dir/scipsdp/SdpVarfixer.c.o CMakeFiles/scipsdp.dir/scipsdp/cons_sdp.c.o CMakeFiles/scipsdp.dir/scipsdp/cons_savedsdpsettings.c.o CMakeFiles/scipsdp.dir/scipsdp/cons_savesdpsol.c.o CMakeFiles/scipsdp.dir/scipsdp/relax_sdp.c.o CMakeFiles/scipsdp.dir/scipsdp/disp_sdpiterations.c.o CMakeFiles/scipsdp.dir/scipsdp/disp_sdpavgiterations.c.o CMakeFiles/scipsdp.dir/scipsdp/disp_sdpfastsettings.c.o CMakeFiles/scipsdp.dir/scipsdp/disp_sdppenalty.c.o CMakeFiles/scipsdp.dir/scipsdp/disp_sdpunsolved.c.o CMakeFiles/scipsdp.dir/scipsdp/prop_sdpredcost.c.o CMakeFiles/scipsdp.dir/scipsdp/branch_sdpmostfrac.c.o CMakeFiles/scipsdp.dir/scipsdp/branch_sdpmostinf.c.o CMakeFiles/scipsdp.dir/scipsdp/branch_sdpobjective.c.o CMakeFiles/scipsdp.dir/scipsdp/branch_sdpinfobjective.c.o CMakeFiles/scipsdp.dir/scipsdp/heur_sdpfracround.c.o CMakeFiles/scipsdp.dir/scipsdp/heur_sdpinnerlp.c.o CMakeFiles/scipsdp.dir/scipsdp/heur_sdpfracdiving.c.o CMakeFiles/scipsdp.dir/scipsdp/heur_sdprand.c.o CMakeFiles/scipsdp.dir/scipsdp/prop_sdpsymmetry.c.o CMakeFiles/scipsdp.dir/scipsdp/prop_sdpobbt.c.o CMakeFiles/scipsdp.dir/scipsdp/prop_companalcent.c.o CMakeFiles/scipsdp.dir/scipsdp/reader_cbf.c.o CMakeFiles/scipsdp.dir/scipsdp/reader_sdpa.c.o CMakeFiles/scipsdp.dir/scipsdp/sdpsymmetry.c.o CMakeFiles/scipsdp.dir/scipsdp/table_relaxsdp.c.o CMakeFiles/scipsdp.dir/scipsdp/table_slater.c.o CMakeFiles/scipsdp.dir/scipsdp/scipsdpdefplugins.c.o CMakeFiles/scipsdp.dir/sdpi/sdpi.c.o CMakeFiles/scipsdp.dir/sdpi/sdpsolchecker.c.o CMakeFiles/scipsdp.dir/sdpi/solveonevarsdp.c.o CMakeFiles/scipsdp.dir/sdpi/lapack_interface.c.o CMakeFiles/scipsdp.dir/sdpi/sdpiclock.c.o CMakeFiles/scipsdp.dir/scipsdpgithash.c.o CMakeFiles/scipsdp.dir/sdpi/sdpisolver_dsdp.c.o CMakeFiles/scipsdp.dir/symmetry/compute_symmetry_bliss.cpp.o -o ../bin/scipsdp  -ldsdp /sage/local/lib/libscip.so.8.0.2.0 -Wl,-Bstatic -lbliss -Wl,-Bdynamic -llapack -lm 
  [scip_sdp-git]   cd /sage/local/var/tmp/sage/build/scip_sdp-git/src/build/src && /usr/bin/cmake -E cmake_symlink_library ../lib/libscipsdp.so.4.1.0 ../lib/libscipsdp.so.4.1 ../lib/libscipsdp.so
  [scip_sdp-git]   [100%] Built target libscipsdp
  [scip_sdp-git]   /usr/sbin/ld: CMakeFiles/scipsdp.dir/sdpi/lapack_interface.c.o: undefined reference to symbol 'dgemm_'
  [scip_sdp-git]   /usr/sbin/ld: /usr/lib/libopenblas.so.3: error adding symbols: DSO missing from command line
  [scip_sdp-git]   collect2: error: ld returned 1 exit status
  [scip_sdp-git]   make[5]: *** [src/CMakeFiles/scipsdp.dir/build.make:695: bin/scipsdp] Error 1

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 10, 2022

comment:41

The failure on opensuse-tumbleweed-minimal is tracked in #34764.

The failure on centos-stream-9-pyhton3.9-minimal is #34786.

The failure on ubuntu-trusty-... comes from #34726.

The failure on conda-forge will disappear when #33842 is merged.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 10, 2022

Changed commit from 8ef2ea4 to b9c9e3d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b9c9e3dbuild/pkgs/scip_sdp/patches/zz_another_blas_change.patch: Link through with blas

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 10, 2022

comment:43

This has fixed archlinux-latest-standard (comment:40)

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 10, 2022

comment:44

Ready for review

@dimpase
Copy link
Member

dimpase commented Dec 11, 2022

comment:45

lgtm

@dimpase
Copy link
Member

dimpase commented Dec 11, 2022

Changed reviewer from https://github.com/mkoeppe/SCIP-SDP/actions/runs/3660649526 to Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 11, 2022

comment:46

Thank you

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2023

comment:47

Pdf docs don't build (#31329 comment:49)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 2, 2023

Changed commit from b9c9e3d to 544d123

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 2, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

d954f18Merge tag '9.8.beta6' into t/34749/package_scip_sdp
544d123build/pkgs/scip_sdp/SPKG.rst: Remove bad unicode

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2023

comment:49

pdf builds now

@vbraun
Copy link
Member

vbraun commented Jan 12, 2023

Changed branch from u/mkoeppe/package_scip_sdp to 544d123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants